Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

Issue 2692423005: rebaseline-cl: Get latest try jobs using git-cl when no --issue given. (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
index 7c47ebccffea4a03e6ca6a001739b7552ee7dd64..c67909e8a4a63e1c09be6ce0151a507c763ff39a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
@@ -4,9 +4,10 @@
import unittest
+from webkitpy.common.host_mock import MockHost
+from webkitpy.common.net.buildbot import Build
from webkitpy.common.net.git_cl import GitCL
from webkitpy.common.system.executive_mock import MockExecutive
-from webkitpy.common.host_mock import MockHost
class GitCLTest(unittest.TestCase):
@@ -94,11 +95,13 @@ class GitCLTest(unittest.TestCase):
'builder_name': 'some-builder',
'status': 'COMPLETED',
'result': 'FAILURE',
+ 'url': 'http://build.chromium.org/p/master/builders/some-builder/builds/90',
},
{
'builder_name': 'some-builder',
'status': 'STARTED',
'result': None,
+ 'url': 'http://build.chromium.org/p/master/builders/some-builder/builds/100',
},
]))
@@ -108,11 +111,13 @@ class GitCLTest(unittest.TestCase):
'builder_name': 'some-builder',
'status': 'COMPLETED',
'result': 'FAILURE',
+ 'url': 'http://build.chromium.org/p/master/builders/some-builder/builds/90',
},
{
'builder_name': 'some-builder',
'status': 'COMPLETED',
'result': 'SUCCESS',
+ 'url': 'http://build.chromium.org/p/master/builders/some-builder/builds/100',
},
]))
@@ -125,11 +130,13 @@ class GitCLTest(unittest.TestCase):
'builder_name': 'some-builder',
'status': 'COMPLETED',
'result': 'SUCCESS',
+ 'url': 'http://build.chromium.org/p/master/builders/some-builder/builds/90',
},
{
'builder_name': 'some-builder',
'status': 'STARTED',
'result': None,
+ 'url': 'http://build.chromium.org/p/master/builders/some-builder/builds/100',
},
]))
@@ -141,3 +148,35 @@ class GitCLTest(unittest.TestCase):
'result': 'FAILURE',
},
]))
+
+ def test_latest_try_builds(self):
+ git_cl = GitCL(MockHost())
+ git_cl.fetch_try_results = lambda: [
+ {
+ 'builder_name': 'builder-b',
+ 'status': 'COMPLETED',
+ 'result': 'SUCCESS',
+ 'url': 'http://build.chromium.org/p/master/builders/some-builder/builds/100',
+ },
+ {
+ 'builder_name': 'builder-b',
+ 'status': 'COMPLETED',
+ 'result': 'SUCCESS',
+ 'url': 'http://build.chromium.org/p/master/builders/some-builder/builds/90',
+ },
+ {
+ 'builder_name': 'builder-a',
+ 'status': 'SCHEDULED',
+ 'result': None,
+ 'url': None,
+ },
+ {
+ 'builder_name': 'builder-c',
+ 'status': 'COMPLETED',
+ 'result': 'SUCCESS',
+ 'url': 'http://build.chromium.org/p/master/builders/some-builder/builds/123',
+ },
+ ]
+ self.assertEqual(
+ git_cl.latest_try_jobs(['builder-a', 'builder-b']),
+ [Build('builder-a'), Build('builder-b', 100)])

Powered by Google App Engine
This is Rietveld 408576698