Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py

Issue 2692423005: rebaseline-cl: Get latest try jobs using git-cl when no --issue given. (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py
index 13ec00c1d9c649fa72798ec2d0a36901236a72a8..a98e89da1affa2e6938fa140031d4a322b12955f 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py
@@ -28,7 +28,7 @@
import unittest
-from webkitpy.common.net.buildbot import BuildBot
+from webkitpy.common.net.buildbot import BuildBot, Build, filter_latest_builds
class BuilderTest(unittest.TestCase):
@@ -57,3 +57,24 @@ class BuilderTest(unittest.TestCase):
buildbot = BuildBot()
buildbot._fetch_file = lambda: None # pylint: disable=protected-access
self.assertIsNone(buildbot.fetch_layout_test_results(buildbot.results_url('Builder')))
+
+
+class BuildBotHelperFunctionTest(unittest.TestCase):
+
+ def test_filter_latest_jobs_empty(self):
+ self.assertEqual(filter_latest_builds([]), [])
+
+ def test_filter_latest_jobs_higher_build_first(self):
+ self.assertEqual(
+ filter_latest_builds([Build('foo', 5), Build('foo', 3), Build('bar', 5)]),
+ [Build('bar', 5), Build('foo', 5)])
+
+ def test_filter_latest_jobs_higher_build_last(self):
+ self.assertEqual(
+ filter_latest_builds([Build('foo', 3), Build('bar', 5), Build('foo', 5)]),
+ [Build('bar', 5), Build('foo', 5)])
+
+ def test_filter_latest_jobs_no_build_number(self):
+ self.assertEqual(
+ filter_latest_builds([Build('foo', 3), Build('bar'), Build('bar')]),
+ [Build('bar'), Build('foo', 3)])

Powered by Google App Engine
This is Rietveld 408576698