Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields. (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index 2732110cbaf14a6577b1fe5e88b772f827b9aa0f..28bf13da2179a54cd7c3ad70c924800e15be0dc1 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -558,7 +558,7 @@ CorePageLoadMetricsObserver::FlushMetricsOnAppEnterBackground(
// app is about to be backgrounded, as part of the Activity.onPause()
// flow. After this method is invoked, Chrome may be killed without further
// notification, so we record final metrics collected up to this point.
- if (!info.committed_url.is_empty()) {
+ if (info.did_commit) {
RecordTimingHistograms(timing, info);
RecordByteAndResourceHistograms(timing, info);
}
@@ -702,7 +702,7 @@ void CorePageLoadMetricsObserver::RecordRappor(
g_browser_process->rappor_service();
if (!rappor_service)
return;
- if (info.committed_url.is_empty())
+ if (!info.did_commit)
return;
// Log the eTLD+1 of sites that show poor loading performance.
@@ -711,8 +711,7 @@ void CorePageLoadMetricsObserver::RecordRappor(
std::unique_ptr<rappor::Sample> sample =
rappor_service->CreateSample(rappor::UMA_RAPPOR_TYPE);
sample->SetStringField(
- "Domain",
- rappor::GetDomainAndRegistrySampleFromGURL(info.committed_url));
+ "Domain", rappor::GetDomainAndRegistrySampleFromGURL(info.url));
uint64_t bucket_index =
RapporHistogramBucketIndex(timing.first_contentful_paint.value());
sample->SetFlagsField("Bucket", uint64_t(1) << bucket_index,
@@ -729,7 +728,6 @@ void CorePageLoadMetricsObserver::RecordRappor(
if (timing.first_paint && !timing.first_meaningful_paint) {
rappor::SampleDomainAndRegistryFromGURL(
rappor_service,
- internal::kRapporMetricsNameFirstMeaningfulPaintNotRecorded,
- info.committed_url);
+ internal::kRapporMetricsNameFirstMeaningfulPaintNotRecorded, info.url);
}
}

Powered by Google App Engine
This is Rietveld 408576698