Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields. (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 58f4856a62e20a7424b33c4f64c7f561460547b2..a2e344789f29ff11a2364df8c901bcee6ac8534e 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -157,7 +157,7 @@ void MetricsWebContentsObserver::WillStartNavigationRequest(
? web_contents()->GetOpener()->GetLastCommittedURL()
: GURL::EmptyGURL();
const GURL& currently_committed_url =
- committed_load_ ? committed_load_->committed_url() : opener_url;
+ committed_load_ ? committed_load_->url() : opener_url;
has_navigated_ = true;
// We can have two provisional loads in some cases. E.g. a same-site
@@ -345,6 +345,7 @@ void MetricsWebContentsObserver::HandleCommittedNavigationForTrackedLoad(
committed_load_ = std::move(tracker);
committed_load_->Commit(navigation_handle);
+ DCHECK(committed_load_->did_commit());
}
void MetricsWebContentsObserver::NavigationStopped() {
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698