Refactor PageLoadExtraInfo::committed_url to url and did_commit fields.

chrome/browser/page_load_metrics/page_load_metrics_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_OBSERVER_H_
 #define CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_OBSERVER_H_
 
 #include "base/macros.h"
 #include "base/optional.h"
 #include "chrome/common/page_load_metrics/page_load_timing.h"
@@ skipping 93 matching lines @@
         user_gesture(user_gesture),
         user_input_event(user_input_event) {}
 };
 
 struct PageLoadExtraInfo {
   PageLoadExtraInfo(
       const base::Optional<base::TimeDelta>& first_background_time,
       const base::Optional<base::TimeDelta>& first_foreground_time,
       bool started_in_foreground,
       UserInitiatedInfo user_initiated_info,
-      const GURL& committed_url,
+      const GURL& url,
       const GURL& start_url,
+      const bool did_commit,

[jkarlin, 2017/02/15 19:55:36]

You have const here but not in the .cc

[Bryan McQuade, 2017/02/15 20:27:10]

Ah, this is unnecessary. I removed it. Thanks!

       UserAbortType abort_type,
       UserInitiatedInfo abort_user_initiated_info,
       const base::Optional<base::TimeDelta>& time_to_abort,
       const PageLoadMetadata& metadata);
 
   PageLoadExtraInfo(const PageLoadExtraInfo& other);
 
   ~PageLoadExtraInfo();
 
   // The first time that the page was backgrounded since the navigation started.
   const base::Optional<base::TimeDelta> first_background_time;
 
   // The first time that the page was foregrounded since the navigation started.
   const base::Optional<base::TimeDelta> first_foreground_time;
 
   // True if the page load started in the foreground.
   const bool started_in_foreground;
 
   // Whether the page load was initiated by a user.
   const UserInitiatedInfo user_initiated_info;
 
-  // Committed URL. If the page load did not commit, |committed_url| will be
-  // empty.
-  const GURL committed_url;
+  // Most recent URL for this page. Can be updated at navigation start, upon
+  // redirection, and at commit time.
+  const GURL url;
 
   // The URL that started the navigation, before redirects.
   const GURL start_url;
 
+  // Whether the navigation for this page load committed.
+  const bool did_commit;
+
   // The abort time and time to abort for this page load. If the page was not
   // aborted, |abort_type| will be |ABORT_NONE|.
   const UserAbortType abort_type;
 
   // Whether the abort for this page load was user initiated. For example, if
   // this page load was aborted by a new navigation, this field tracks whether
   // that new navigation was user-initiated. This field is only useful if this
   // page load's abort type is a value other than ABORT_NONE. Note that this
   // value is currently experimental, and is subject to change. In particular,
   // this field is not currently set for some abort types, such as stop and
@@ skipping 172 matching lines @@
       const FailedProvisionalLoadInfo& failed_provisional_load_info,
       const PageLoadExtraInfo& extra_info) {}
 
   // Called whenever a request is loaded for this page load.
   virtual void OnLoadedResource(const ExtraRequestInfo& extra_request_info) {}
 };
 
 }  // namespace page_load_metrics
 
 #endif  // CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_OBSERVER_H_