Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: pkg/analysis_server/test/src/plugin/notification_manager_test.dart

Issue 2692373002: Add the notification manager (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/src/plugin/notification_manager_test.dart
diff --git a/pkg/analysis_server/test/src/plugin/notification_manager_test.dart b/pkg/analysis_server/test/src/plugin/notification_manager_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..003750f1d9b17e6d83ebdecbfe1977a4578d280f
--- /dev/null
+++ b/pkg/analysis_server/test/src/plugin/notification_manager_test.dart
@@ -0,0 +1,500 @@
+// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:analysis_server/plugin/protocol/protocol.dart' as server;
+import 'package:analysis_server/src/channel/channel.dart';
+import 'package:analysis_server/src/plugin/notification_manager.dart';
+import 'package:analyzer/file_system/memory_file_system.dart';
+import 'package:analyzer_plugin/protocol/protocol.dart' as plugin;
+import 'package:analyzer_plugin/protocol/protocol_constants.dart' as plugin;
+import 'package:analyzer_plugin/protocol/protocol_generated.dart' as plugin;
+import 'package:test/test.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+
+import 'protocol_test_utilities.dart';
+
+main() {
+ defineReflectiveSuite(() {
+ defineReflectiveTests(NotificationManagerTest);
+ });
+}
+
+@reflectiveTest
+class NotificationManagerTest extends ProtocolTestUtilities {
+ String testDir;
+ String fileA;
+ String fileB;
+
+ TestChannel channel;
+
+ NotificationManager manager;
+
+ void setUp() {
+ MemoryResourceProvider provider = new MemoryResourceProvider();
+ testDir = provider.convertPath('/test');
+ fileA = provider.convertPath('/test/a.dart');
+ fileB = provider.convertPath('/test/b.dart');
+ channel = new TestChannel();
+ manager = new NotificationManager(channel, provider);
+ }
+
+ void test_handlePluginNotification_errors() {
+ manager.setAnalysisRoots([testDir], []);
+ plugin.AnalysisError pluginError1 = pluginAnalysisError(0, 0, file: fileA);
+ plugin.AnalysisError pluginError2 = pluginAnalysisError(3, 4, file: fileA);
+ plugin.AnalysisErrorsParams params =
+ new plugin.AnalysisErrorsParams(fileA, [pluginError1, pluginError2]);
+ manager.handlePluginNotification('a', params.toNotification());
+
+ server.AnalysisError serverError1 = serverAnalysisError(0, 0, file: fileA);
+ server.AnalysisError serverError2 = serverAnalysisError(3, 4, file: fileA);
+ _verifyErrors(fileA, [serverError1, serverError2]);
+ }
+
+ void test_handlePluginNotification_folding() {
+ manager.setSubscriptions({
+ server.AnalysisService.FOLDING: [fileA, fileB]
+ });
+ plugin.FoldingRegion pluginRegion1 = pluginFoldingRegion(10, 3);
+ plugin.FoldingRegion pluginRegion2 = pluginFoldingRegion(20, 6);
+ plugin.AnalysisFoldingParams params =
+ new plugin.AnalysisFoldingParams(fileA, [pluginRegion1, pluginRegion2]);
+ manager.handlePluginNotification('a', params.toNotification());
+
+ server.FoldingRegion serverRegion1 = serverFoldingRegion(10, 3);
+ server.FoldingRegion serverRegion2 = serverFoldingRegion(20, 6);
+ _verifyFoldingRegions(fileA, [serverRegion1, serverRegion2]);
+ }
+
+ void test_handlePluginNotification_highlights() {
+ manager.setSubscriptions({
+ server.AnalysisService.HIGHLIGHTS: [fileA, fileB]
+ });
+ plugin.HighlightRegion pluginRegion1 = pluginHighlightRegion(10, 3);
+ plugin.HighlightRegion pluginRegion2 = pluginHighlightRegion(20, 6);
+ plugin.AnalysisHighlightsParams params =
+ new plugin.AnalysisHighlightsParams(
+ fileA, [pluginRegion1, pluginRegion2]);
+
+ server.HighlightRegion serverRegion1 = serverHighlightRegion(10, 3);
+ server.HighlightRegion serverRegion2 = serverHighlightRegion(20, 6);
+ manager.handlePluginNotification('a', params.toNotification());
+ _verifyHighlightRegions(fileA, [serverRegion1, serverRegion2]);
+ }
+
+ void test_handlePluginNotification_naviation() {
+ manager.setSubscriptions({
+ server.AnalysisService.NAVIGATION: [fileA, fileB]
+ });
+ plugin.AnalysisNavigationParams pluginParams =
+ pluginNavigationParams(0, 0, file: fileA);
+ manager.handlePluginNotification('a', pluginParams.toNotification());
+
+ server.AnalysisNavigationParams serverParams =
+ serverNavigationParams(0, 0, file: fileA);
+ _verifyNavigationParams(serverParams);
+ }
+
+ void test_handlePluginNotification_occurences() {
+ manager.setSubscriptions({
+ server.AnalysisService.OCCURRENCES: [fileA, fileB]
+ });
+ plugin.Occurrences pluginOccurrences1 = pluginOccurrences(0, 0);
+ plugin.Occurrences pluginOccurrences2 = pluginOccurrences(5, 7);
+ plugin.AnalysisOccurrencesParams params =
+ new plugin.AnalysisOccurrencesParams(
+ fileA, [pluginOccurrences1, pluginOccurrences2]);
+
+ server.Occurrences serverOccurrences1 = serverOccurrences(0, 0);
+ server.Occurrences serverOccurrences2 = serverOccurrences(5, 7);
+ manager.handlePluginNotification('a', params.toNotification());
+ _verifyOccurrences(fileA, [serverOccurrences1, serverOccurrences2]);
+ }
+
+ void test_handlePluginNotification_outline() {
+ manager.setSubscriptions({
+ server.AnalysisService.OUTLINE: [fileA, fileB]
+ });
+ plugin.Outline pluginOutline1 = pluginOutline(0, 0);
+ plugin.AnalysisOutlineParams params =
+ new plugin.AnalysisOutlineParams(fileA, [pluginOutline1]);
+ manager.handlePluginNotification('a', params.toNotification());
+
+ server.Outline serverOutline1 = serverOutline(0, 0);
+ _verifyOutlines(fileA, serverOutline1);
+ }
+
+ void test_recordAnalysisErrors_noSubscription() {
+ server.AnalysisError error = serverAnalysisError(0, 0, file: fileA);
+ manager.recordAnalysisErrors('a', fileA, [error]);
+ expect(channel.sentNotification, isNull);
+ }
+
+ void test_recordAnalysisErrors_withSubscription() {
+ manager.setAnalysisRoots([testDir], []);
+ //
+ // Errors should be reported when they are recorded.
+ //
+ server.AnalysisError error1 = serverAnalysisError(0, 0, file: fileA);
+ server.AnalysisError error2 = serverAnalysisError(3, 4, file: fileA);
+ manager.recordAnalysisErrors('a', fileA, [error1, error2]);
+ _verifyErrors(fileA, [error1, error2]);
+ //
+ // Errors from different plugins should be cumulative.
+ //
+ server.AnalysisError error3 = serverAnalysisError(6, 8, file: fileA);
+ manager.recordAnalysisErrors('b', fileA, [error3]);
+ _verifyErrors(fileA, [error1, error2, error3]);
+ //
+ // Overwriting errors from one plugin should not affect errors from other
+ // plugins.
+ //
+ server.AnalysisError error4 = serverAnalysisError(9, 12, file: fileA);
+ manager.recordAnalysisErrors('a', fileA, [error4]);
+ _verifyErrors(fileA, [error4, error3]);
+ //
+ // Recording errors against a file should not affect the errors for other
+ // files.
+ //
+ server.AnalysisError error5 = serverAnalysisError(12, 16, file: fileB);
+ manager.recordAnalysisErrors('a', fileB, [error5]);
+ _verifyErrors(fileB, [error5]);
+ }
+
+ void test_recordFoldingRegions_noSubscription() {
+ server.FoldingRegion region = serverFoldingRegion(10, 5);
+ manager.recordFoldingRegions('a', fileA, [region]);
+ expect(channel.sentNotification, isNull);
+ }
+
+ void test_recordFoldingRegions_withSubscription() {
+ manager.setSubscriptions({
+ server.AnalysisService.FOLDING: [fileA, fileB]
+ });
+ //
+ // Regions should be reported when they are recorded.
+ //
+ server.FoldingRegion region1 = serverFoldingRegion(10, 3);
+ server.FoldingRegion region2 = serverFoldingRegion(20, 6);
+ manager.recordFoldingRegions('a', fileA, [region1, region2]);
+ _verifyFoldingRegions(fileA, [region1, region2]);
+ //
+ // Regions from different plugins should be cumulative.
+ //
+ server.FoldingRegion region3 = serverFoldingRegion(30, 5);
+ manager.recordFoldingRegions('b', fileA, [region3]);
+ _verifyFoldingRegions(fileA, [region1, region2, region3]);
+ //
+ // Overwriting regions from one plugin should not affect regions from other
+ // plugins.
+ //
+ server.FoldingRegion region4 = serverFoldingRegion(40, 2);
+ manager.recordFoldingRegions('a', fileA, [region4]);
+ _verifyFoldingRegions(fileA, [region4, region3]);
+ //
+ // Recording regions against a file should not affect the regions for other
+ // files.
+ //
+ server.FoldingRegion region5 = serverFoldingRegion(50, 7);
+ manager.recordFoldingRegions('a', fileB, [region5]);
+ _verifyFoldingRegions(fileB, [region5]);
+ }
+
+ void test_recordHighlightRegions_noSubscription() {
+ server.HighlightRegion region = serverHighlightRegion(10, 5);
+ manager.recordHighlightRegions('a', fileA, [region]);
+ expect(channel.sentNotification, isNull);
+ }
+
+ void test_recordHighlightRegions_withSubscription() {
+ manager.setSubscriptions({
+ server.AnalysisService.HIGHLIGHTS: [fileA, fileB]
+ });
+ //
+ // Regions should be reported when they are recorded.
+ //
+ server.HighlightRegion region1 = serverHighlightRegion(10, 3);
+ server.HighlightRegion region2 = serverHighlightRegion(20, 6);
+ manager.recordHighlightRegions('a', fileA, [region1, region2]);
+ _verifyHighlightRegions(fileA, [region1, region2]);
+ //
+ // Regions from different plugins should be cumulative.
+ //
+ server.HighlightRegion region3 = serverHighlightRegion(30, 5);
+ manager.recordHighlightRegions('b', fileA, [region3]);
+ _verifyHighlightRegions(fileA, [region1, region2, region3]);
+ //
+ // Overwriting regions from one plugin should not affect regions from other
+ // plugins.
+ //
+ server.HighlightRegion region4 = serverHighlightRegion(40, 2);
+ manager.recordHighlightRegions('a', fileA, [region4]);
+ _verifyHighlightRegions(fileA, [region4, region3]);
+ //
+ // Recording regions against a file should not affect the regions for other
+ // files.
+ //
+ server.HighlightRegion region5 = serverHighlightRegion(50, 7);
+ manager.recordHighlightRegions('a', fileB, [region5]);
+ _verifyHighlightRegions(fileB, [region5]);
+ }
+
+ void test_recordNavigationParams_noSubscription() {
+ server.AnalysisNavigationParams params =
+ serverNavigationParams(0, 0, file: fileA);
+ manager.recordNavigationParams('a', fileA, params);
+ expect(channel.sentNotification, isNull);
+ }
+
+ void test_recordNavigationParams_withSubscription() {
+ manager.setSubscriptions({
+ server.AnalysisService.NAVIGATION: [fileA, fileB]
+ });
+ //
+ // Parameters should be reported when they are recorded.
+ //
+ server.AnalysisNavigationParams params1 =
+ serverNavigationParams(0, 0, file: fileA);
+ manager.recordNavigationParams('a', fileA, params1);
+ _verifyNavigationParams(params1);
+ //
+ // Parameters from different plugins should be cumulative.
+ //
+ server.AnalysisNavigationParams params2 =
+ serverNavigationParams(2, 4, file: fileA);
+ manager.recordNavigationParams('b', fileA, params2);
+ server.AnalysisNavigationParams params1and2 =
+ new server.AnalysisNavigationParams(fileA, <server.NavigationRegion>[
+ new server.NavigationRegion(0, 2, <int>[0]),
+ new server.NavigationRegion(4, 2, <int>[1])
+ ], <server.NavigationTarget>[
+ new server.NavigationTarget(server.ElementKind.FIELD, 0, 1, 2, 2, 3),
+ new server.NavigationTarget(server.ElementKind.FIELD, 2, 5, 2, 6, 7)
+ ], <String>[
+ 'aa',
+ 'ab',
+ 'ac',
+ 'ad'
+ ]);
+ _verifyNavigationParams(params1and2);
+ //
+ // Overwriting parameters from one plugin should not affect parameters from
+ // other plugins.
+ //
+ server.AnalysisNavigationParams params3 =
+ serverNavigationParams(4, 8, file: fileA);
+ manager.recordNavigationParams('a', fileA, params3);
+ server.AnalysisNavigationParams params3and2 =
+ new server.AnalysisNavigationParams(fileA, <server.NavigationRegion>[
+ new server.NavigationRegion(8, 2, <int>[0]),
+ new server.NavigationRegion(4, 2, <int>[1])
+ ], <server.NavigationTarget>[
+ new server.NavigationTarget(server.ElementKind.FIELD, 0, 9, 2, 10, 11),
+ new server.NavigationTarget(server.ElementKind.FIELD, 2, 5, 2, 6, 7)
+ ], <String>[
+ 'ae',
+ 'af',
+ 'ac',
+ 'ad'
+ ]);
+ _verifyNavigationParams(params3and2);
+ //
+ // Recording parameters against a file should not affect the parameters for
+ // other files.
+ //
+ server.AnalysisNavigationParams params4 =
+ serverNavigationParams(6, 12, file: fileB);
+ manager.recordNavigationParams('a', fileB, params4);
+ _verifyNavigationParams(params4);
+ }
+
+ void test_recordOccurrences_noSubscription() {
+ server.Occurrences occurrences = serverOccurrences(0, 0);
+ manager.recordOccurrences('a', fileA, [occurrences]);
+ expect(channel.sentNotification, isNull);
+ }
+
+ void test_recordOccurrences_withSubscription() {
+ manager.setSubscriptions({
+ server.AnalysisService.OCCURRENCES: [fileA, fileB]
+ });
+ //
+ // Occurrences should be reported when they are recorded.
+ //
+ server.Occurrences occurrences1 = serverOccurrences(0, 0);
+ server.Occurrences occurrences2 = serverOccurrences(5, 7);
+ manager.recordOccurrences('a', fileA, [occurrences1, occurrences2]);
+ _verifyOccurrences(fileA, [occurrences1, occurrences2]);
+ //
+ // Occurrences from different plugins should be cumulative.
+ //
+ server.Occurrences occurrences3 = serverOccurrences(10, 14);
+ manager.recordOccurrences('b', fileA, [occurrences3]);
+ _verifyOccurrences(fileA, [occurrences1, occurrences2, occurrences3]);
+ //
+ // Overwriting occurrences from one plugin should not affect occurrences
+ // from other plugins.
+ //
+ server.Occurrences occurrences4 = serverOccurrences(15, 21);
+ manager.recordOccurrences('a', fileA, [occurrences4]);
+ _verifyOccurrences(fileA, [occurrences4, occurrences3]);
+ //
+ // Recording occurrences against a file should not affect the occurrences
+ // for other files.
+ //
+ server.Occurrences occurrences5 = serverOccurrences(20, 28);
+ manager.recordOccurrences('a', fileB, [occurrences5]);
+ _verifyOccurrences(fileB, [occurrences5]);
+ }
+
+ void test_recordOutlines_noSubscription() {
+ server.Outline outline = serverOutline(0, 0);
+ manager.recordOutlines('a', fileA, [outline]);
+ expect(channel.sentNotification, isNull);
+ }
+
+ @failingTest
+ void test_recordOutlines_withSubscription() {
+ fail('The outline handling needs to be re-worked slightly');
+ // TODO(brianwilkerson) Figure out outlines. What should we do when merge
+ // cannot produce a single outline?
+ manager.setSubscriptions({
+ server.AnalysisService.OUTLINE: [fileA, fileB]
+ });
+ //
+ // Outlines should be reported when they are recorded.
+ //
+ server.Outline outline1 = serverOutline(0, 0);
+ server.Outline outline2 = serverOutline(5, 7);
+ manager.recordOutlines('a', fileA, [outline1, outline2]);
+ // TODO(brianwilkerson) Figure out how to test this.
+// _verifyOutlines(fileA, [outline1, outline2]);
+ //
+ // Outlines from different plugins should be cumulative.
+ //
+ server.Outline outline3 = serverOutline(10, 14);
+ manager.recordOutlines('b', fileA, [outline3]);
+ // TODO(brianwilkerson) Figure out how to test this.
+// _verifyOutlines(fileA, [outline1, outline2, outline3]);
+ //
+ // Overwriting outlines from one plugin should not affect outlines from
+ // other plugins.
+ //
+ server.Outline outline4 = serverOutline(15, 21);
+ manager.recordOutlines('a', fileA, [outline4]);
+ // TODO(brianwilkerson) Figure out how to test this.
+// _verifyOutlines(fileA, [outline4, outline3]);
+ //
+ // Recording outlines against a file should not affect the outlines for
+ // other files.
+ //
+ server.Outline outline5 = serverOutline(20, 28);
+ manager.recordOutlines('a', fileB, [outline5]);
+ // TODO(brianwilkerson) Figure out how to test this.
+// _verifyOutlines(fileB, [outline5]);
+ }
+
+ void _verifyErrors(
+ String fileName, List<server.AnalysisError> expectedErrors) {
+ server.Notification notification = channel.sentNotification;
+ expect(notification, isNotNull);
+ expect(notification.event, 'analysis.errors');
+ server.AnalysisErrorsParams params =
+ new server.AnalysisErrorsParams.fromNotification(notification);
+ expect(params, isNotNull);
+ expect(params.file, fileName);
+ expect(params.errors, equals(expectedErrors));
+ channel.sentNotification = null;
+ }
+
+ void _verifyFoldingRegions(
+ String fileName, List<server.FoldingRegion> expectedRegions) {
+ server.Notification notification = channel.sentNotification;
+ expect(notification, isNotNull);
+ expect(notification.event, 'analysis.folding');
+ server.AnalysisFoldingParams params =
+ new server.AnalysisFoldingParams.fromNotification(notification);
+ expect(params, isNotNull);
+ expect(params.file, fileName);
+ expect(params.regions, equals(expectedRegions));
+ channel.sentNotification = null;
+ }
+
+ void _verifyHighlightRegions(
+ String fileName, List<server.HighlightRegion> expectedRegions) {
+ server.Notification notification = channel.sentNotification;
+ expect(notification, isNotNull);
+ expect(notification.event, 'analysis.highlights');
+ server.AnalysisHighlightsParams params =
+ new server.AnalysisHighlightsParams.fromNotification(notification);
+ expect(params, isNotNull);
+ expect(params.file, fileName);
+ expect(params.regions, equals(expectedRegions));
+ channel.sentNotification = null;
+ }
+
+ void _verifyNavigationParams(server.AnalysisNavigationParams expectedParams) {
+ server.Notification notification = channel.sentNotification;
+ expect(notification, isNotNull);
+ expect(notification.event, 'analysis.navigation');
+ server.AnalysisNavigationParams params =
+ new server.AnalysisNavigationParams.fromNotification(notification);
+ expect(params, isNotNull);
+ expect(params.file, expectedParams.file);
+ expect(params.files, equals(expectedParams.files));
+ expect(params.regions, equals(expectedParams.regions));
+ expect(params.targets, equals(expectedParams.targets));
+ channel.sentNotification = null;
+ }
+
+ void _verifyOccurrences(
+ String fileName, List<server.Occurrences> expectedOccurrences) {
+ server.Notification notification = channel.sentNotification;
+ expect(notification, isNotNull);
+ expect(notification.event, 'analysis.occurrences');
+ server.AnalysisOccurrencesParams params =
+ new server.AnalysisOccurrencesParams.fromNotification(notification);
+ expect(params, isNotNull);
+ expect(params.file, fileName);
+ expect(params.occurrences, equals(expectedOccurrences));
+ channel.sentNotification = null;
+ }
+
+ void _verifyOutlines(String fileName, server.Outline expectedOutline) {
+ server.Notification notification = channel.sentNotification;
+ expect(notification, isNotNull);
+ expect(notification.event, 'analysis.outline');
+ server.AnalysisOutlineParams params =
+ new server.AnalysisOutlineParams.fromNotification(notification);
+ expect(params, isNotNull);
+ expect(params.file, fileName);
+ expect(params.outline, equals(expectedOutline));
+ channel.sentNotification = null;
+ }
+}
+
+class TestChannel implements ServerCommunicationChannel {
+ server.Notification sentNotification;
+
+ @override
+ void close() {
+ fail('Unexpected invocation of close');
+ }
+
+ @override
+ void listen(void onRequest(server.Request request),
+ {Function onError, void onDone()}) {
+ fail('Unexpected invocation of listen');
+ }
+
+ @override
+ void sendNotification(server.Notification notification) {
+ sentNotification = notification;
+ }
+
+ @override
+ void sendResponse(server.Response response) {
+ fail('Unexpected invocation of sendResponse');
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698