Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

Issue 2692343005: [Bindings] Unify a template block 'prepare_prototype_and_interface_object' (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
index e3ecd1fae80151651269fa35ecd36dcdc130b55b..9e0e34b4c0b90182edec736c3baa2777d8d7907b 100644
--- a/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
@@ -862,62 +862,6 @@ v8::Local<v8::Object> {{v8_class}}::findInstanceInPrototypeChain(v8::Local<v8::V
{##############################################################################}
-{% block prepare_prototype_and_interface_object %}
-{% from 'methods.cpp.tmpl' import install_conditionally_enabled_methods with context %}
-{% if has_prepare_prototype_and_interface_object %}
-void {{v8_class}}::preparePrototypeAndInterfaceObject(v8::Local<v8::Context> context, const DOMWrapperWorld& world, v8::Local<v8::Object> prototypeObject, v8::Local<v8::Function> interfaceObject, v8::Local<v8::FunctionTemplate> interfaceTemplate) {
- v8::Isolate* isolate = context->GetIsolate();
-{% if unscopables %}
- {{install_unscopables() | indent(2)}}
-{% endif %}
-{% if has_conditional_attributes_on_prototype %}
- {{install_conditionally_enabled_attributes_on_prototype() | indent(2)}}
-{% endif %}
-{% if methods | conditionally_exposed(is_partial) %}
- {{install_conditionally_enabled_methods() | indent(2)}}
-{% endif %}
-}
-
-{% endif %}
-{% endblock %}
-
-
-{##############################################################################}
-{% macro install_unscopables() %}
-v8::Local<v8::Name> unscopablesSymbol(v8::Symbol::GetUnscopables(isolate));
-v8::Local<v8::Object> unscopables;
-if (v8CallBoolean(prototypeObject->HasOwnProperty(context, unscopablesSymbol)))
- unscopables = prototypeObject->Get(context, unscopablesSymbol).ToLocalChecked().As<v8::Object>();
-else
- unscopables = v8::Object::New(isolate);
-{% for name, runtime_enabled_feature_name in unscopables %}
-{% filter runtime_enabled(runtime_enabled_feature_name) %}
-unscopables->CreateDataProperty(context, v8AtomicString(isolate, "{{name}}"), v8::True(isolate)).FromJust();
-{% endfilter %}
-{% endfor %}
-prototypeObject->CreateDataProperty(context, unscopablesSymbol, unscopables).FromJust();
-{% endmacro %}
-
-
-{##############################################################################}
-{% macro install_conditionally_enabled_attributes_on_prototype() %}
-{% from 'attributes.cpp.tmpl' import attribute_configuration with context %}
-ExecutionContext* executionContext = toExecutionContext(context);
-v8::Local<v8::Signature> signature = v8::Signature::New(isolate, interfaceTemplate);
-{% for attribute in attributes if (attribute.exposed_test or attribute.secure_context_test) and attribute.on_prototype %}
-{% filter exposed(attribute.exposed_test) %}
-{% filter secure_context(attribute.secure_context_test) %}
-{% filter runtime_enabled(attribute.runtime_enabled_feature_name) %}
-const V8DOMConfiguration::AccessorConfiguration accessorConfiguration = {{attribute_configuration(attribute)}};
-V8DOMConfiguration::installAccessor(isolate, world, v8::Local<v8::Object>(), prototypeObject, interfaceObject, signature, accessorConfiguration);
-{% endfilter %}{# runtime_enabled #}
-{% endfilter %}{# secure_context #}
-{% endfilter %}{# exposed #}
-{% endfor %}
-{% endmacro %}
-
-
-{##############################################################################}
{% block partial_interface %}
{% if has_partial_interface %}
{% if needs_runtime_enabled_installer %}

Powered by Google App Engine
This is Rietveld 408576698