Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2692303002: Split InterceptorData (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split InterceptorData - into InterceptorData, InterceptorDataBuilder and OneShotInterceptorData. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/00094ca18eec8e3f3cf2155abc0d7a03e7671455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -110 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 9 chunks +25 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/interceptor_data.dart View 10 chunks +146 lines, -66 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 3 chunks +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-14 15:40:04 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-17 23:08:37 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-02-20 11:55:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00094ca18eec8e3f3cf2155abc0d7a03e7671455 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698