content/common/input/web_input_event_traits.h - Issue 26923002: Consolidate WebInputEvent coalescing logic

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/input/web_input_event_traits.h

Issue 26923002: Consolidate WebInputEvent coalescing logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/renderer_host/input/gesture_event_filter.cc ('K') | « content/browser/renderer_host/input/touch_event_queue.cc ('k') | content/common/input/web_input_event_traits.cc » ('j') | content/common/input/web_input_event_traits.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_COMMON_INPUT_WEB_INPUT_EVENT_TRAITS_H_	5 #ifndef CONTENT_COMMON_INPUT_WEB_INPUT_EVENT_TRAITS_H_

6 #define CONTENT_COMMON_INPUT_WEB_INPUT_EVENT_TRAITS_H_	6 #define CONTENT_COMMON_INPUT_WEB_INPUT_EVENT_TRAITS_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "content/common/input/scoped_web_input_event.h"	9 #include "content/common/input/scoped_web_input_event.h"

10 #include "third_party/WebKit/public/web/WebInputEvent.h"	10 #include "third_party/WebKit/public/web/WebInputEvent.h"

11	11

12 namespace content {	12 namespace content {

13	13

14 // Utility class for performing operations on and with WebInputEvents.	14 // Utility class for performing operations on and with WebInputEvents.

15 class WebInputEventTraits {	15 class WebInputEventTraits {

16 public:	16 public:

17 static size_t GetSize(WebKit::WebInputEvent::Type type);	17 static size_t GetSize(WebKit::WebInputEvent::Type type);

18 static ScopedWebInputEvent Clone(const WebKit::WebInputEvent& event);	18 static ScopedWebInputEvent Clone(const WebKit::WebInputEvent& event);

19 static void Delete(WebKit::WebInputEvent* event);	19 static void Delete(WebKit::WebInputEvent* event);

	20 static bool TryCoalesce(const WebKit::WebInputEvent& event_to_coalesce,
	jdduke (slow) 2013/10/10 21:21:26 Any guidance on arg ordering here? I prefer "TryCo Any guidance on arg ordering here? I prefer "TryCoalesceWith(event, const_event)", but I vaguely recall a Chromium preference for trailing pointer args. Maybe just rename "TryCoalesceInto"?
	21 WebKit::WebInputEvent* event);

20 };	22 };

21	23

22 } // namespace content	24 } // namespace content

23	25

24 #endif // CONTENT_COMMON_INPUT_WEB_INPUT_EVENT_TRAITS_H_	26 #endif // CONTENT_COMMON_INPUT_WEB_INPUT_EVENT_TRAITS_H_

OLD	NEW