Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2573)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2692273008: Hacky slashy (Closed)
Patch Set: fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/allocator.gni ('k') | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 069f10b98123f4560bee01bcdaaea8cf674e22e3..bcecf286c1335ca68d1ae81f761ce491b7925ae3 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -161,6 +161,8 @@ config("compiler") {
configs += [ "//build/config/nacl:compiler" ]
} else if (is_ios || is_mac) {
configs += [ "//build/config/mac:compiler" ]
+ } else if (is_fuchsia) {
+ configs += [ "//build/config/fuchsia:compiler" ]
}
# Applies to all Posix systems.
@@ -298,7 +300,7 @@ config("compiler") {
# Linux/Android common flags setup.
# ---------------------------------
- if (is_linux || is_android) {
+ if (is_linux || is_android || is_fuchsia) {
cflags += [
"-fPIC",
"-pipe", # Use pipes for communicating between sub-processes. Faster.
@@ -326,7 +328,11 @@ config("compiler") {
"-lpthread",
]
}
- ldflags += [ "-Wl,--as-needed" ]
+ if (!is_fuchsia) {
+ # We need mxio/magenta to get linked in, even if they're not directly
+ # referenced.
+ ldflags += [ "-Wl,--as-needed" ]
jamesr 2017/02/18 00:55:28 recording for posterity: you can have this flag, t
+ }
}
}
« no previous file with comments | « build/config/allocator.gni ('k') | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698