Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/toolchain/toolchain.gni

Issue 2692273008: Hacky slashy (Closed)
Patch Set: tidy up required gn flags, use sdk Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/fuchsia/BUILD.gn ('K') | « build/toolchain/fuchsia/BUILD.gn ('k') | extensions/features/features.gni » ('j') | remoting/remoting_enable.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/toolchain.gni
diff --git a/build/toolchain/toolchain.gni b/build/toolchain/toolchain.gni
index 5722c125d0073196a0476e37541ecf9f9493aa9e..15dd0c7a3a728c5278e940245359e7ec4ba713c0 100644
--- a/build/toolchain/toolchain.gni
+++ b/build/toolchain/toolchain.gni
@@ -88,6 +88,8 @@ if (is_mac || is_ios) {
shlib_extension = ".so"
} else if (is_win) {
shlib_extension = ".dll"
+} else if (is_fuchsia) {
+ shlib_extension = ".so" # ?
jamesr 2017/02/18 00:18:40 ".so" is correct for fuchsia
jamesr 2017/02/18 00:18:40 ".so" is correct for fuchsia
scottmg 2017/02/18 00:25:19 Done.
} else {
assert(false, "Platform not supported")
}
« build/config/fuchsia/BUILD.gn ('K') | « build/toolchain/fuchsia/BUILD.gn ('k') | extensions/features/features.gni » ('j') | remoting/remoting_enable.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698