base/process/process_handle_fuchsia.cc - Issue 2692273008: Hacky slashy

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/process/process_handle_fuchsia.cc

Issue 2692273008: Hacky slashy (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/macros.h"

	6 #include "base/process/process_handle.h"

	7

	8 namespace base {

	9

	10 ProcessId GetParentProcessId(ProcessHandle process) {

	11 // TODO(scottmg): Port.

	12 return 0;

	13 }

	14

	15 FilePath GetProcessExecutablePath(ProcessHandle process) {

	16 // TODO(scottmg): Port.

	17 return FilePath();
	cpu_(ooo_6.6-7.5) 2017/02/20 23:22:15 there might not be a file backing a process, but t there might not be a file backing a process, but there is a free form \|name\| property that if you squint reads (sometimes) like a path via mx_object_get_property(handle, MX_PROP_NAME, name, sizeof(name)); better than nothing ... scottmg 2017/02/21 00:30:16 Thanks, had a go at that. (This function seems to Show quoted text On 2017/02/20 23:22:15, cpu wrote: > there might not be a file backing a process, but there is a free form \|name\| > property that if you squint reads (sometimes) like a path via > > mx_object_get_property(handle, MX_PROP_NAME, name, sizeof(name)); > > better than nothing ... Thanks, had a go at that. (This function seems to see very limited use based on https://cs.chromium.org/search/?q=GetProcessExecutablePath+package:%5Echromiu... , so I'm not sure if this works or not.)
	18 }

	19

	20 } // namespace base

OLD	NEW