Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: services/ui/ws/server_window.cc

Issue 2692223003: Remove FrameSinkId hierarchy when unparenting ServerWindow. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/ws/server_window.cc
diff --git a/services/ui/ws/server_window.cc b/services/ui/ws/server_window.cc
index 64f79e26433a72fb031b6da5422cd2adbf15dcc3..654b40aab2a22aedda40373387ca9519a25e850b 100644
--- a/services/ui/ws/server_window.cc
+++ b/services/ui/ws/server_window.cc
@@ -146,8 +146,12 @@ void ServerWindow::Remove(ServerWindow* child) {
for (auto& observer : child->observers_)
observer.OnWillChangeWindowHierarchy(child, nullptr, this);
+
RemoveImpl(child);
+ if (GetRoot() != nullptr)
+ child->ProcessRootChanged(GetRoot(), nullptr);
+
// Stack the child properly if it is a transient child of a sibling.
if (child->transient_parent_ && child->transient_parent_->parent() == this)
RestackTransientDescendants(child->transient_parent_, &GetStackingTarget,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698