Reland: MD Settings: Fix the Network Prediction toggle box.

chrome/test/data/webui/settings/settings_toggle_button_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for settings-toggle-button. */
 cr.define('settings_toggle_button', function() {
   function registerTests() {
     suite('SettingsToggleButton', function() {
       /**
        * Toggle button created before each test.
@@ skipping 13 matching lines @@
           key: 'test',
           type: chrome.settingsPrivate.PrefType.BOOLEAN,
           value: true
         };
         PolymerTest.clearBody();
         testElement = document.createElement('settings-toggle-button');
         testElement.set('pref', pref);
         document.body.appendChild(testElement);
       });
 
-      test('responds to checked attribute', function() {
-        assertTrue(testElement.checked);
-
-        testElement.removeAttribute('checked');
-        assertFalse(testElement.checked);
-        assertFalse(testElement.pref.value);
-
-        testElement.setAttribute('checked', '');
-        assertTrue(testElement.checked);
-        assertTrue(testElement.pref.value);
-      });
-
       test('value changes on tap', function() {
         assertTrue(testElement.checked);
         assertTrue(testElement.pref.value);
 
         MockInteractions.tap(testElement.$.control);
         assertFalse(testElement.checked);
         assertFalse(testElement.pref.value);
 
         MockInteractions.tap(testElement.$.control);
         assertTrue(testElement.checked);
@@ skipping 23 matching lines @@
       test('numerical pref', function() {
         var prefNum = {
           key: 'test',
           type: chrome.settingsPrivate.PrefType.NUMBER,
           value: 1
         };
 
         testElement.set('pref', prefNum);
         assertTrue(testElement.checked);
 
-        testElement.removeAttribute('checked');
+        MockInteractions.tap(testElement.$.control);
         assertFalse(testElement.checked);
         assertEquals(0, prefNum.value);
 
-        testElement.setAttribute('checked', '');
+        MockInteractions.tap(testElement.$.control);
         assertTrue(testElement.checked);
         assertEquals(1, prefNum.value);
       });
+
+      test('numerical pref with custom values', function() {
+        var prefNum = {
+          key: 'test',
+          type: chrome.settingsPrivate.PrefType.NUMBER,
+          value: 5
+        };
+
+        testElement.numericUncheckedValue = 5;
+
+        testElement.set('pref', prefNum);
+        assertFalse(testElement.checked);
+
+        MockInteractions.tap(testElement.$.control);
+        assertTrue(testElement.checked);
+        assertEquals(1, prefNum.value);
+
+        MockInteractions.tap(testElement.$.control);
+        assertFalse(testElement.checked);
+        assertEquals(5, prefNum.value);
+      });
+
+      test('numerical pref with unknown inital value', function() {
+        prefNum = {
+          key: 'test',
+          type: chrome.settingsPrivate.PrefType.NUMBER,
+          value: 3
+        };
+
+        testElement.numericUncheckedValue = 5;

[Dan Beam, 2017/02/15 23:25:53]

you might need to change this

[tommycli, 2017/02/15 23:36:52]

Done.

+
+        testElement.set('pref', prefNum);
+
+        // Unknown value should still count as checked.
+        assertTrue(testElement.checked);
+
+        // The control should not clobber an existing unknown value.
+        assertEquals(3, prefNum.value);
+
+        // Unchecking should still send the unchecked value to prefs.
+        MockInteractions.tap(testElement.$.control);
+        assertFalse(testElement.checked);
+        assertEquals(5, prefNum.value);
+
+        // Checking should still send the normal checked value to prefs.
+        MockInteractions.tap(testElement.$.control);
+        assertTrue(testElement.checked);
+        assertEquals(1, prefNum.value);
+      });
     });
   }
 
   return {
     registerTests: registerTests,
   };
 });