Chromium Code Reviews| Index: media/audio/audio_system.h |
| diff --git a/media/audio/audio_system.h b/media/audio/audio_system.h |
| index a11b030c742ab22e6b195f2a40388decd7df488c..76319cc2eb75aa1f84c513f030ce9f6729c9e872 100644 |
| --- a/media/audio/audio_system.h |
| +++ b/media/audio/audio_system.h |
| @@ -25,11 +25,26 @@ class MEDIA_EXPORT AudioSystem { |
| virtual ~AudioSystem(); |
| - // Callback will receive invalid parameters if the device is not found. |
| + // Callback may receive invalid parameters, it means the specified device is |
| + // not found. This is best-effort: valid parameters do not guarantee existance |
| + // of the device. |
| + // TODO(olka,tommi): fix all AudioManager implementations to return invalid |
|
tommi (sloooow) - chröme
2017/02/16 08:04:12
w00t - I getz todo too! Thanks for updating the c
|
| + // parameters if the device is not found. |
| virtual void GetInputStreamParameters( |
| const std::string& device_id, |
| OnAudioParamsCallback on_params_cb) const = 0; |
| + // If media::AudioDeviceDescription::IsDefaultDevice(device_id) is true, |
| + // callback will receive the parameters of the default output device. |
| + // Callback may receive invalid parameters, it means the specified device is |
| + // not found. This is best-effort: valid parameters do not guarantee existance |
| + // of the device. |
| + // TODO(olka,tommi): fix all AudioManager implementations to return invalid |
| + // parameters if the device is not found. |
| + virtual void GetOutputStreamParameters( |
| + const std::string& device_id, |
| + OnAudioParamsCallback on_params_cb) const = 0; |
| + |
| virtual void HasInputDevices(OnBoolCallback on_has_devices_cb) const = 0; |
| // Must not be used for anything but stream creation. |