Issue 26922004: Make sure attribute indexes are correct after restoring vertex attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26922004: Make sure attribute indexes are correct after restoring vertex attributes (Closed)

Created:
7 years, 2 months ago by Kimmo Kinnunen

Modified:
7 years, 2 months ago

Reviewers:
jvanverth1, bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Make sure attribute indexes are correct after restoring vertex attributes Fix an assert due to GrDrawState::CommonState::fFixedFunctionVertexAttribIndices getting out of sync. The assertion in GrDrawState::CommonState::operator== would fire after using AutoVertexAttribRestore. AutoVertexAttribRestore would change GrDrawState::fCommon.fVAPtr and fVACount without updating GrDrawState::fCommon.fFixedFunctionVertexAttribIndices. Committed: http://code.google.com/p/skia/source/detail?r=11807

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/gpu/GrDrawState.h	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/26922004/1

7 years, 2 months ago (2013-10-16 14:20:58 UTC) #3

Message was sent while issue was closed.

Change committed as 11807

Expand Messages | Collapse Messages