chrome/browser/extensions/extension_apitest.cc - Issue 2692153002: Enable SiteIsolationExtensions trial for developers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_apitest.cc

Issue 2692153002: Enable SiteIsolationExtensions trial for developers. (Closed)

Patch Set: Fix extensions test by initializing the test config later in test startup sequence. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_apitest.cc

diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc

index 2b1bb049bb3122f5504ff4cdc1253010e6fd3057..6ef8b057c06042938d177bb48504c751feb41517 100644

--- a/chrome/browser/extensions/extension_apitest.cc

+++ b/chrome/browser/extensions/extension_apitest.cc

@@ -151,7 +151,8 @@ ExtensionApiTest::ExtensionApiTest() {

ExtensionApiTest::~ExtensionApiTest() {}

-void ExtensionApiTest::SetUpInProcessBrowserTestFixture() {

+void ExtensionApiTest::SetUpOnMainThread() {

+ ExtensionBrowserTest::SetUpOnMainThread();

DCHECK(!test_config_.get()) << "Previous test did not clear config state.";

test_config_.reset(new base::DictionaryValue());

test_config_->SetString(kTestDataDirectory,