chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc - Issue 2692153002: Enable SiteIsolationExtensions trial for developers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc

Issue 2692153002: Enable SiteIsolationExtensions trial for developers. (Closed)

Patch Set: Fix failing test classes subclassing ExtensionApiTest. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('j') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc

index 574cd8367bf92ab08d58caf5d4fdfc14c08170fa..e7abad92c1523cf1efa827bc8d8a424519a8ab92 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc

@@ -104,7 +104,7 @@ class NetworkingPrivateServiceClientApiTest : public ExtensionApiTest {

void TearDownOnMainThread() override {

content::RunAllPendingInMessageLoop();

- ExtensionApiTest::SetUpOnMainThread();

Devlin 2017/02/15 19:24:34 Heh not the first time I've seen this. It'd be gr

nasko 2017/02/15 19:34:57 Acknowledged.

+ ExtensionApiTest::TearDownOnMainThread();

}

protected: