Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 26921005: Add VP9 decode support to the remoting client. (Closed)

Created:
7 years, 2 months ago by Wez
Modified:
7 years, 2 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add VP9 decode support to the remoting client. BUG=260879 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230003

Patch Set 1 : Rebase. #

Patch Set 2 : Disable VP9 correctly in hosts. #

Total comments: 4

Patch Set 3 : Update libvpx/webm comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -5 lines) Patch
M remoting/client/rectangle_update_decoder.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/codec/video_decoder_vpx.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M remoting/codec/video_decoder_vpx.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M remoting/codec/video_encoder_vpx.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M remoting/codec/video_encoder_vpx.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/proto/video.proto View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/content_description.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/session_config.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M remoting/protocol/session_config.cc View 1 2 chunks +20 lines, -1 line 0 comments Download
M remoting/protocol/video_reader.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Wez
PTAL
7 years, 2 months ago (2013-10-21 05:26:04 UTC) #1
Jamie
LGTM with my comments addressed (or ignored). https://codereview.chromium.org/26921005/diff/32001/remoting/codec/video_encoder_vpx.cc File remoting/codec/video_encoder_vpx.cc (right): https://codereview.chromium.org/26921005/diff/32001/remoting/codec/video_encoder_vpx.cc#newcode202 remoting/codec/video_encoder_vpx.cc:202: image_->y_chroma_shift = ...
7 years, 2 months ago (2013-10-21 18:28:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/26921005/102001
7 years, 2 months ago (2013-10-21 22:55:05 UTC) #3
Wez
https://codereview.chromium.org/26921005/diff/32001/remoting/codec/video_encoder_vpx.cc File remoting/codec/video_encoder_vpx.cc (right): https://codereview.chromium.org/26921005/diff/32001/remoting/codec/video_encoder_vpx.cc#newcode202 remoting/codec/video_encoder_vpx.cc:202: image_->y_chroma_shift = 1; On 2013/10/21 18:28:20, Jamie wrote: > ...
7 years, 2 months ago (2013-10-22 01:13:01 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 01:53:41 UTC) #5
Message was sent while issue was closed.
Change committed as 230003

Powered by Google App Engine
This is Rietveld 408576698