Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2692093004: Revert: StringCanonicalizer for Fasta (Closed)

Created:
3 years, 10 months ago by Dmitry Olshansky
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Revert: StringCanonicalizer for Fasta #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -130 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/scanner/canonicalizer.dart View 1 chunk +0 lines, -118 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 5 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dmitry Olshansky
3 years, 10 months ago (2017-02-14 16:17:52 UTC) #2
Dmitry Olshansky
Reverting due to ripple effect across the code base.
3 years, 10 months ago (2017-02-14 16:19:14 UTC) #4
ahe
lgtm :-(
3 years, 10 months ago (2017-02-14 16:20:37 UTC) #5
Vyacheslav Egorov (Google)
lgtm
3 years, 10 months ago (2017-02-14 16:21:01 UTC) #6
Dmitry Olshansky
3 years, 10 months ago (2017-02-14 16:24:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bf1eeab38e8f468b46410b5319dd11165cc2a4b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698