Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2692073002: Add AnalysisDriver.getUnitElementSignature() for checking without resynthesizing. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add AnalysisDriver.getUnitElementSignature() for checking without resynthesizing. Just like _computeAnalysisResult() uses _getResolvedUnitKey() to check cache for existing results without _createLibraryContext(), we need Angular plugin to use getUnitElementSignature() to check whether there are existing analysis results. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/126b10adf8644e5fc4ce9655542bf043f6e59ffd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -10 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 7 chunks +65 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-13 19:25:26 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-13 20:29:10 UTC) #2
scheglov
3 years, 10 months ago (2017-02-13 20:45:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
126b10adf8644e5fc4ce9655542bf043f6e59ffd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698