Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: runtime/vm/kernel_to_il.cc

Issue 2691943008: VM: [Kernel] Make [DirectMethodInvocation]s also work for setters/getters (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 #include <set> 6 #include <set>
7 #include <string> 7 #include <string>
8 8
9 #include "vm/kernel_to_il.h" 9 #include "vm/kernel_to_il.h"
10 10
(...skipping 4811 matching lines...) Expand 10 before | Expand all | Expand 10 after
4822 } 4822 }
4823 4823
4824 fragment_ = instructions + InstanceCall(node->position(), name, token_kind, 4824 fragment_ = instructions + InstanceCall(node->position(), name, token_kind,
4825 argument_count, argument_names, 4825 argument_count, argument_names,
4826 num_args_checked); 4826 num_args_checked);
4827 } 4827 }
4828 4828
4829 4829
4830 void FlowGraphBuilder::VisitDirectMethodInvocation( 4830 void FlowGraphBuilder::VisitDirectMethodInvocation(
4831 DirectMethodInvocation* node) { 4831 DirectMethodInvocation* node) {
4832 const dart::String& method_name = H.DartMethodName(node->target()->name()); 4832 const dart::String& method_name = H.DartProcedureName(node->target());
4833 const Function& target = Function::ZoneHandle( 4833 const Function& target = Function::ZoneHandle(
4834 Z, LookupMethodByMember(node->target(), method_name)); 4834 Z, LookupMethodByMember(node->target(), method_name));
4835 4835
4836 intptr_t argument_count = node->arguments()->count() + 1; 4836 intptr_t argument_count = node->arguments()->count() + 1;
4837 Array& argument_names = Array::ZoneHandle(Z); 4837 Array& argument_names = Array::ZoneHandle(Z);
4838 4838
4839 // TODO(28109) Support generic methods in the VM or reify them away. 4839 // TODO(28109) Support generic methods in the VM or reify them away.
4840 Fragment instructions = TranslateExpression(node->receiver()); 4840 Fragment instructions = TranslateExpression(node->receiver());
4841 instructions += PushArgument(); 4841 instructions += PushArgument();
4842 instructions += TranslateArguments(node->arguments(), &argument_names); 4842 instructions += TranslateArguments(node->arguments(), &argument_names);
(...skipping 1488 matching lines...) Expand 10 before | Expand all | Expand 10 after
6331 thread->clear_sticky_error(); 6331 thread->clear_sticky_error();
6332 return error.raw(); 6332 return error.raw();
6333 } 6333 }
6334 } 6334 }
6335 6335
6336 6336
6337 } // namespace kernel 6337 } // namespace kernel
6338 } // namespace dart 6338 } // namespace dart
6339 6339
6340 #endif // !defined(DART_PRECOMPILED_RUNTIME) 6340 #endif // !defined(DART_PRECOMPILED_RUNTIME)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698