fix quick unlock config in options

chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
 
   /**
+   * Maximum time to wait after the page is fully loaded before
+   * we start to load polymer elements.

[Dan Beam, 2017/02/17 02:45:17]

please wrap comments at 80 cols

[xiaoyinh(OOO Sep 11-29), 2017/02/17 19:33:46]

Done.

+   * @type {number}
+   * @const
+   */
+  var POLYMER_LOAD_TIMEOUT_MS = 5000;
+
+  /**
    * QuickUnlockConfigureOverlay class
    * Dialog that allows users to configure screen lock.
    * @constructor
    * @extends {cr.ui.pageManager.Page}
    */
   function QuickUnlockConfigureOverlay() {
     Page.call(this, 'quickUnlockConfigureOverlay',
               loadTimeData.getString('lockScreenTitle'),
               'quick-unlock-configure-overlay');
 
   }
 
   cr.addSingletonGetter(QuickUnlockConfigureOverlay);
 
   QuickUnlockConfigureOverlay.prototype = {
     __proto__: Page.prototype,
 
     /** @override */
     initializePage: function() {
       Page.prototype.initializePage.call(this);
       $('screen-lock-done').onclick = function() {
         QuickUnlockConfigureOverlay.dismiss();
       };
+
+      document.onreadystatechange = function () {

[Dan Beam, 2017/02/17 02:45:17]

this is not properly formatted, please run git cl format --js

[xiaoyinh(OOO Sep 11-29), 2017/02/17 19:33:46]

Done.

+        if (document.readyState == "complete") {
+          // Setting a timeout here to avoid racing with some browsertests,

[Dan Beam, 2017/02/17 02:45:17]

i don't think this guarantees anything about racing with browser tests

[xiaoyinh(OOO Sep 11-29), 2017/02/17 19:33:46]

Thanks, I think the failed browsertests are running after the options page is
loaded. Setting a timeout here so that the browser tests could complete before
we start to load the polymer elements. I understand this is not ideal and
guaranteed, but I'm not sure if there's another way to do it? Is there a way to
know if this is running as part of the browsertests vs regular routes?

+          // this should be here for only a short period of time as
+          // md-settings are launching soon.
+          setTimeout(this.ensurePolymerIsLoaded_.bind(this),
+                     POLYMER_LOAD_TIMEOUT_MS);
+        }
+      }.bind(this);

[Dan Beam, 2017/02/17 02:45:17]

can you just do

window.addEventListener('load', function() {

}.bind(this));

instead?

[xiaoyinh(OOO Sep 11-29), 2017/02/17 19:33:46]

Done.

     },
 
     /** @override */
     didClosePage: function() {
       settings.navigateTo(settings.Route.PEOPLE);
     },
 
     /** @override */
     didShowPage: function() {
       this.ensurePolymerIsLoaded_().then(this.onPolymerLoaded_.bind(this));
@@ skipping 17 matching lines @@
     /**
      * Called when polymer has been loaded and the dialog should be displayed.
      * @private
      */
     onPolymerLoaded_: function() {
       settings.navigateTo(settings.Route.LOCK_SCREEN);
       var lockScreen = document.querySelector('settings-lock-screen');
 
       var checkbox =
           lockScreen.root.querySelector(
-              'div.settings-box.single-column.screen-lock');
+              'div.settings-box');

[Dan Beam, 2017/02/17 02:45:17]

please reformat this with git cl format --js

[xiaoyinh(OOO Sep 11-29), 2017/02/17 19:33:46]

Done.

       checkbox.hidden = true;
 
       var passwordPrompt = lockScreen.root.
           querySelector('settings-password-prompt-dialog');
       passwordPrompt.addEventListener('close', function() {
         if (!lockScreen.setModes_) {
           QuickUnlockConfigureOverlay.dismiss();
         }
       }.bind(this));
     },
   };
 
   QuickUnlockConfigureOverlay.dismiss = function() {
     PageManager.closeOverlay();
   };
 
   // Export
   return {
     QuickUnlockConfigureOverlay: QuickUnlockConfigureOverlay
   };
 });