Proto checkdeps added ignoring partial paths.

Proto checkdeps added ignoring partial paths.

Previous attempt to write a proto dependency checker is updated so that partial paths are ignrored for now. This will be changed when Chromium source is updated so that all paths are complete paths.
Next step is marked in http://crbug.com/691451.

BUG=684383
R=brettw@chromium.org

Committed: 4ca3556cb7098968142bb18f9eb0d1ea40c327f0

patch from issue 2653023004 at patchset 20001 (http://crrev.com/2653023004#ps20001)

Committed: a114b81a60affa28b3816d01791908e8f87a260d

[Ramin Halavati, 2017-02-13 09:59:55]

Hi,

Following the email thread, proto checkdeps is updated so that it will ignore
partial paths for now. A bug is filed for updating Chrome source to have full
paths, and after that we can disable this exception.

Please review.

[Ramin Halavati, 2017-02-15 14:27:53]

On 2017/02/13 09:59:55, Ramin Halavati wrote:
> Hi,
> 
> Following the email thread, proto checkdeps is updated so that it will ignore
> partial paths for now. A bug is filed for updating Chrome source to have full
> paths, and after that we can disable this exception.
> 
> Please review.

A friendly ping on this.

[brettw, 2017-02-23 21:45:41]

I was out sick and I noticed this under my pile of email.

Is this still valid? It looks identical to
https://codereview.chromium.org/2653023004 Is that true or did something change?
If it's the same, can you explain why it's OK to reland now?

[Ramin Halavati, 2017-02-24 09:56:44]

On 2017/02/23 21:45:41, brettw (plz ping after 24h) wrote:
> I was out sick and I noticed this under my pile of email.
> 
> Is this still valid? It looks identical to
> https://codereview.chromium.org/2653023004 Is that true or did something
change?
> If it's the same, can you explain why it's OK to reland now?

The problem with previous version was it did not allow partial proto paths and
required updating all current usages of partial protos before landing.

In this new version, (in lines 78-78 of checkdeps/proto_checker.py), we check
that if a proto path is partial, it is ignored and dependency check is only done
if complete paths are provided.

crbug.com/691451 is is filed to follow up on these missing cases.

[Ramin Halavati, 2017-02-24 09:57:28]

rhalavati@chromium.org changed reviewers:
+ xyzzyz@chromium.org

[Ramin Halavati, 2017-02-24 09:57:29]

+xyzzyz@

[brettw, 2017-02-24 22:08:59]

LGTM.

Next time this happens it's nice to upload the previous patch as the first patch
set so the reviewer can see what changed from last time, and to call out why the
reland is happening in the messages.

[Ramin Halavati, 2017-02-27 08:53:58]

rhalavati@chromium.org changed reviewers:
+ msramek@chromium.org

[Ramin Halavati, 2017-02-27 08:53:59]

brettw@:
Thank you, sorry for the inconvenience.

msramek@:
Could you please land it, I still cannot do it as I am not committer.

[msramek, 2017-02-27 12:50:23]

Description was changed from

==========
Proto checkdeps added ignoring partial paths.

Previous attempt to write a proto dependency checker is updated so that partial
paths are ignrored for now. This will be changed when Chromium source is updated
so that all paths are complete paths.
Next step is marked in http://crbug.com/691451.

BUG=684383
R=brettw@chromium.org

Committed: 4ca3556cb7098968142bb18f9eb0d1ea40c327f0

patch from issue 2653023004 at patchset 20001
(http://crrev.com/2653023004#ps20001)
==========

to

==========
Proto checkdeps added ignoring partial paths.

Previous attempt to write a proto dependency checker is updated so that partial
paths are ignrored for now. This will be changed when Chromium source is updated
so that all paths are complete paths.
Next step is marked in http://crbug.com/691451.

BUG=684383
R=brettw@chromium.org

Committed: 4ca3556cb7098968142bb18f9eb0d1ea40c327f0

patch from issue 2653023004 at patchset 20001
(http://crrev.com/2653023004#ps20001)

Committed: a114b81a60affa28b3816d01791908e8f87a260d
==========

[msramek, 2017-02-27 12:50:24]

Committed patchset #1 (id:1) manually as
a114b81a60affa28b3816d01791908e8f87a260d (presubmit successful).