Rotate an image bitmap in ImageLoader extension when loading detached.

ui/file_manager/image_loader/image_loader.js

Index: ui/file_manager/image_loader/image_loader.js
diff --git a/ui/file_manager/image_loader/image_loader.js b/ui/file_manager/image_loader/image_loader.js
index 3f26ea17243b17f50ecdffe9e70c4b9fa64ebae9..72d0f1ee4398e0d87957077df5c5487854c8aad5 100644
--- a/ui/file_manager/image_loader/image_loader.js
+++ b/ui/file_manager/image_loader/image_loader.js
@@ -71,6 +71,9 @@ function ImageLoader() {
           if (typeof request.orientation === 'number') {
             request.orientation =
                 ImageOrientation.fromDriveOrientation(request.orientation);
+          } else if (request.orientation) {
+            request.orientation =
+                ImageOrientation.fromRotationAndScale(request.orientation);

[mtomasz, 2017/02/17 02:49:18]

I know the logic here already did it, but it shouldn't be responsibility of
image loader to perform conversions to different orientation formats. Image
loader shouldn't have dependency on file manager code, as it's a separate
extension.


Can we move both ImageOrientation.fromDriveOrientation and
ImageOrientation.fromRotationAndScale calls to the calling files? Then this
logic will become simpler, and we'll get rid of the circular dependency.


If it's significant refactoring, then doing it in a separate CL is fine.

[yamaguchi, 2017/02/17 03:44:40]

As discussed offline, we'll need to handle the circular dependency problem
separately, because it is also happening with other files.
Orientation is a class (which has prototype chain, unlike a  plain hash map).
We'd need to make sure if we can do that across extensions.
I will be removing the handling of "Drive Orientation" with this parameter in a
separate CL, because I haven't seen a code passing Drive Orientation so far.

           } else {
             request.orientation = new ImageOrientation(1, 0, 0, 1);
           }
@@ -127,4 +130,4 @@ ImageLoader.getInstance = function() {
   if (!ImageLoader.instance_)
     ImageLoader.instance_ = new ImageLoader();
   return ImageLoader.instance_;
-};
+};