Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: components/favicon/ios/web_favicon_driver.h

Issue 2691933004: Avoid cyclic dependency FaviconHandler<-->FaviconDriverImpl (Closed)
Patch Set: Addressed more comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/favicon_handler_unittest.cc ('k') | components/favicon/ios/web_favicon_driver.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/ios/web_favicon_driver.h
diff --git a/components/favicon/ios/web_favicon_driver.h b/components/favicon/ios/web_favicon_driver.h
index 59cfca2e2d074931cee773c3cdc780679366205a..9b9e7d004dad6428da9dd6a76508d53926dbb338 100644
--- a/components/favicon/ios/web_favicon_driver.h
+++ b/components/favicon/ios/web_favicon_driver.h
@@ -33,9 +33,13 @@ class WebFaviconDriver : public web::WebStateObserver,
void FetchFavicon(const GURL& url) override;
gfx::Image GetFavicon() const override;
bool FaviconIsValid() const override;
- int StartDownload(const GURL& url, int max_bitmap_size) override;
- bool IsOffTheRecord() override;
GURL GetActiveURL() override;
+
+ // FaviconHandler::Delegate implementation.
+ int DownloadImage(const GURL& url,
+ int max_image_size,
+ ImageDownloadCallback callback) override;
+ bool IsOffTheRecord() override;
void OnFaviconUpdated(
const GURL& page_url,
FaviconDriverObserver::NotificationIconType notification_icon_type,
« no previous file with comments | « components/favicon/core/favicon_handler_unittest.cc ('k') | components/favicon/ios/web_favicon_driver.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698