Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: components/favicon/ios/web_favicon_driver.mm

Issue 2691933004: Avoid cyclic dependency FaviconHandler<-->FaviconDriverImpl (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/ios/web_favicon_driver.mm
diff --git a/components/favicon/ios/web_favicon_driver.mm b/components/favicon/ios/web_favicon_driver.mm
index 03777812d270aaab8087036341b4f3035fc340a0..a80a7e200ab0c0cde3c9953aa4e96d9bb80d122b 100644
--- a/components/favicon/ios/web_favicon_driver.mm
+++ b/components/favicon/ios/web_favicon_driver.mm
@@ -49,16 +49,15 @@ bool WebFaviconDriver::FaviconIsValid() const {
return item ? item->GetFavicon().valid : false;
}
-int WebFaviconDriver::StartDownload(const GURL& url, int max_image_size) {
+int WebFaviconDriver::DownloadImage(const GURL& url,
+ int max_image_size,
+ ImageDownloadCallback callback) {
if (WasUnableToDownloadFavicon(url)) {
DVLOG(1) << "Skip Failed FavIcon: " << url;
return 0;
}
- return web_state()->DownloadImage(
- url, true, max_image_size, false,
- base::Bind(&FaviconDriverImpl::DidDownloadFavicon,
- base::Unretained(this)));
+ return web_state()->DownloadImage(url, true, max_image_size, false, callback);
}
bool WebFaviconDriver::IsOffTheRecord() {

Powered by Google App Engine
This is Rietveld 408576698