Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Issue 2691903007: Update top_level_prefixed_library_test.lib library name. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update top_level_prefixed_library_test.lib library name. The following error was reported on bots with the new analysis driver, but it was not reported before, because DartWorkManager.getErrors() skips non-Dart sources. WARNING|STATIC_WARNING|PART_OF_DIFFERENT_LIBRARY|/b/build/slave/azr-be/build/sdk/tests/language/top_level_prefixed_library_test.lib|6|6|22|Expected this library to be part of 'TopLevelPrefixedLibrary', not 'TopLevelMultipleFilesTest.dart'. The test does not state its intentions, so I did my best guess and fixed the library name. R=hausner@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6e2cf37e900f701d9a914575694001ddd1c04c54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/language/top_level_prefixed_library_test.lib View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
scheglov
3 years, 10 months ago (2017-02-15 02:58:41 UTC) #1
Brian Wilkerson
Sorry, but I have no idea whether this is a reasonable change. Perhaps an e-mail ...
3 years, 10 months ago (2017-02-15 04:46:00 UTC) #2
scheglov
On 2017/02/15 04:46:00, Brian Wilkerson wrote: > Sorry, but I have no idea whether this ...
3 years, 10 months ago (2017-02-15 16:42:13 UTC) #5
hausner
LGTM. Another option may be to remove the '.dart' suffix in the other library clauses ...
3 years, 10 months ago (2017-02-16 07:55:11 UTC) #7
scheglov
3 years, 10 months ago (2017-02-16 15:02:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6e2cf37e900f701d9a914575694001ddd1c04c54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698