third_party/WebKit/LayoutTests/http/tests/background_sync/oneshot.html - Issue 2691903005: ServiceWorker: Change base URL for parsing script URL and scope URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/background_sync/oneshot.html

Issue 2691903005: ServiceWorker: Change base URL for parsing script URL and scope URL (Closed)

Patch Set: Fix tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-iframe.https.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-iframe.https.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-reload.html » ('j') | third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/background_sync/oneshot.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/background_sync/oneshot.html b/third_party/WebKit/LayoutTests/http/tests/background_sync/oneshot.html

index 24ae30ed7b343e7117411237250462efb5fbea54..553c45d51a516a77540acc683f2f17ebe0dec065 100644

--- a/third_party/WebKit/LayoutTests/http/tests/background_sync/oneshot.html

+++ b/third_party/WebKit/LayoutTests/http/tests/background_sync/oneshot.html

@@ -27,7 +27,7 @@ promise_test(function(t) {

})

.then(function(frame) {

var w = frame.contentWindow;

- return w.navigator.serviceWorker.getRegistration(scope);

+ return w.navigator.serviceWorker.getRegistration('oneshot.html');

falken 2017/02/24 06:49:27 I prefer to not repeat the 'oneshot.html' string.

jungkees 2017/02/24 12:25:26 Done.

})

.then(function(sw_registration_frame) {

sync_manager = sw_registration_frame.sync;