Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 269183008: HPACK changes required for specification draft '07 (Closed)

Created:
6 years, 7 months ago by Johnny
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

HPACK changes required for specification draft '07 * The static Huffman table has been updated. * The static header table has been updated. * Several opcodes have been reordered, and have new wire formats. * New never-indexed opcode is decoded (but not encoded). Also removed tolerance for variations in "cookie" casing, to match current consensus on strict header name casing. This lands server change 66241100 by jgraettinger. BUG=339578

Patch Set 1 #

Patch Set 2 : Write '07 examples as a new file name. Remove previous one. #

Total comments: 2

Patch Set 3 : Add a2b_hex to spdy_test_utils, and include it from there. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+648 lines, -571 lines) Patch
D net/data/spdy_tests/examples.hpack View 1 Binary file 0 comments Download
A net/data/spdy_tests/examples_07.hpack View 1 Binary file 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_util_test.cc View 1 2 4 chunks +10 lines, -6 lines 0 comments Download
M net/spdy/hpack_constants.h View 2 chunks +22 lines, -23 lines 0 comments Download
M net/spdy/hpack_constants.cc View 1 chunk +258 lines, -257 lines 0 comments Download
M net/spdy/hpack_decoder.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/spdy/hpack_decoder.cc View 7 chunks +15 lines, -17 lines 0 comments Download
M net/spdy/hpack_decoder_test.cc View 1 2 25 chunks +182 lines, -120 lines 0 comments Download
M net/spdy/hpack_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_encoder_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/hpack_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_header_table.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_header_table.cc View 1 chunk +52 lines, -51 lines 0 comments Download
M net/spdy/hpack_huffman_table_test.cc View 1 2 3 chunks +16 lines, -13 lines 0 comments Download
M net/spdy/hpack_input_stream.h View 3 chunks +3 lines, -8 lines 0 comments Download
M net/spdy/hpack_input_stream.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M net/spdy/hpack_input_stream_test.cc View 1 2 6 chunks +19 lines, -16 lines 0 comments Download
M net/spdy/hpack_output_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_string_util.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_framer_test.cc View 21 chunks +45 lines, -45 lines 0 comments Download
M net/spdy/spdy_test_utils.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_utils.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnny
6 years, 7 months ago (2014-05-06 22:01:17 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/269183008/diff/20001/net/spdy/hpack_huffman_table_test.cc File net/spdy/hpack_huffman_table_test.cc (right): https://codereview.chromium.org/269183008/diff/20001/net/spdy/hpack_huffman_table_test.cc#newcode107 net/spdy/hpack_huffman_table_test.cc:107: string a2b_hex(const char* hex_data) { nit: should we ...
6 years, 7 months ago (2014-05-06 22:28:06 UTC) #2
Johnny
6 years, 7 months ago (2014-05-06 22:43:16 UTC) #3
https://codereview.chromium.org/269183008/diff/20001/net/spdy/hpack_huffman_t...
File net/spdy/hpack_huffman_table_test.cc (right):

https://codereview.chromium.org/269183008/diff/20001/net/spdy/hpack_huffman_t...
net/spdy/hpack_huffman_table_test.cc:107: string a2b_hex(const char* hex_data) {
On 2014/05/06 22:28:07, Ryan Hamilton wrote:
> nit: should we consider moving this elsewhere? (I think it's in a previous
file,
> too)

Done. Moved to spdy_test_utils.cc.

Powered by Google App Engine
This is Rietveld 408576698