Index: components/metrics/metrics_log.h |
diff --git a/components/metrics/metrics_log.h b/components/metrics/metrics_log.h |
index fb4bef2b9d7dcafe61dce481adb60c6f58c1b9e5..751b70cb9b6ee47a782ac6d0a67b85d47b7cf1e5 100644 |
--- a/components/metrics/metrics_log.h |
+++ b/components/metrics/metrics_log.h |
@@ -95,7 +95,7 @@ class MetricsLog { |
// synthetic trial such that the group is determined by the pref value. The |
// current environment is returned serialized as a string. |
std::string RecordEnvironment( |
- const std::vector<MetricsProvider*>& metrics_providers, |
+ const std::vector<std::unique_ptr<MetricsProvider>>& metrics_providers, |
ke.he
2017/02/12 10:14:39
I just changed the interface definition.
An altern
Ilya Sherman
2017/02/13 19:21:30
I think this change is fine -- there's no intent t
|
const std::vector<variations::ActiveGroupId>& synthetic_trials, |
int64_t install_date, |
int64_t metrics_reporting_enabled_date); |
@@ -116,13 +116,13 @@ class MetricsLog { |
// as number of incomplete shutdowns as well as extra breakpad and debugger |
// stats. |
void RecordStabilityMetrics( |
- const std::vector<MetricsProvider*>& metrics_providers, |
+ const std::vector<std::unique_ptr<MetricsProvider>>& metrics_providers, |
base::TimeDelta incremental_uptime, |
base::TimeDelta uptime); |
// Records general metrics based on the specified |metrics_providers|. |
void RecordGeneralMetrics( |
- const std::vector<MetricsProvider*>& metrics_providers); |
+ const std::vector<std::unique_ptr<MetricsProvider>>& metrics_providers); |
// Stop writing to this record and generate the encoded representation. |
// None of the Record* methods can be called after this is called. |