Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: chrome/browser/chromeos/external_metrics.cc

Issue 2691803002: Remove ScopedVector in //component/metrics (Closed)
Patch Set: Remove ScopedVector in //component/metrics Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromecast/browser/metrics/external_metrics.cc » ('j') | components/metrics/metrics_log.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/external_metrics.cc
diff --git a/chrome/browser/chromeos/external_metrics.cc b/chrome/browser/chromeos/external_metrics.cc
index 78f071e1f574ba24cfd93cdc623c80684b2e3610..1b4c0f551359949ad91c7f137762ba62832425c0 100644
--- a/chrome/browser/chromeos/external_metrics.cc
+++ b/chrome/browser/chromeos/external_metrics.cc
@@ -132,13 +132,11 @@ void ExternalMetrics::RecordSparseHistogram(
}
int ExternalMetrics::CollectEvents() {
- ScopedVector<metrics::MetricSample> samples;
+ std::vector<std::unique_ptr<metrics::MetricSample>> samples;
Ilya Sherman 2017/02/13 19:21:30 Please #include <vector> and <memory> at the top o
ke.he 2017/02/14 04:24:14 Done.
metrics::SerializationUtils::ReadAndTruncateMetricsFromFile(uma_events_file_,
&samples);
- for (ScopedVector<metrics::MetricSample>::iterator it = samples.begin();
- it != samples.end();
- ++it) {
+ for (auto it = samples.begin(); it != samples.end(); ++it) {
const metrics::MetricSample& sample = **it;
// Do not use the UMA_HISTOGRAM_... macros here. They cache the Histogram
« no previous file with comments | « no previous file | chromecast/browser/metrics/external_metrics.cc » ('j') | components/metrics/metrics_log.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698