Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chromecast/browser/metrics/external_metrics.cc

Issue 2691803002: Remove ScopedVector in //component/metrics (Closed)
Patch Set: Remove ScopedVector in //component/metrics Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/browser/metrics/external_metrics.h" 5 #include "chromecast/browser/metrics/external_metrics.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 void ExternalMetrics::RecordSparseHistogram( 99 void ExternalMetrics::RecordSparseHistogram(
100 const ::metrics::MetricSample& sample) { 100 const ::metrics::MetricSample& sample) {
101 CHECK_EQ(::metrics::MetricSample::SPARSE_HISTOGRAM, sample.type()); 101 CHECK_EQ(::metrics::MetricSample::SPARSE_HISTOGRAM, sample.type());
102 base::HistogramBase* counter = base::SparseHistogram::FactoryGet( 102 base::HistogramBase* counter = base::SparseHistogram::FactoryGet(
103 sample.name(), base::HistogramBase::kUmaTargetedHistogramFlag); 103 sample.name(), base::HistogramBase::kUmaTargetedHistogramFlag);
104 counter->Add(sample.sample()); 104 counter->Add(sample.sample());
105 } 105 }
106 106
107 int ExternalMetrics::CollectEvents() { 107 int ExternalMetrics::CollectEvents() {
108 ScopedVector< ::metrics::MetricSample> samples; 108 std::vector<std::unique_ptr<::metrics::MetricSample>> samples;
109 ::metrics::SerializationUtils::ReadAndTruncateMetricsFromFile( 109 ::metrics::SerializationUtils::ReadAndTruncateMetricsFromFile(
110 uma_events_file_, &samples); 110 uma_events_file_, &samples);
111 111
112 for (ScopedVector< ::metrics::MetricSample>::iterator it = samples.begin(); 112 for (auto it = samples.begin(); it != samples.end(); ++it) {
113 it != samples.end();
114 ++it) {
115 const ::metrics::MetricSample& sample = **it; 113 const ::metrics::MetricSample& sample = **it;
116 114
117 switch (sample.type()) { 115 switch (sample.type()) {
118 case ::metrics::MetricSample::CRASH: 116 case ::metrics::MetricSample::CRASH:
119 RecordCrash(sample.name()); 117 RecordCrash(sample.name());
120 break; 118 break;
121 case ::metrics::MetricSample::USER_ACTION: 119 case ::metrics::MetricSample::USER_ACTION:
122 CastMetricsHelper::GetInstance()->RecordSimpleAction(sample.name()); 120 CastMetricsHelper::GetInstance()->RecordSimpleAction(sample.name());
123 break; 121 break;
124 case ::metrics::MetricSample::HISTOGRAM: 122 case ::metrics::MetricSample::HISTOGRAM:
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 content::BrowserThread::FILE, 156 content::BrowserThread::FILE,
159 FROM_HERE, 157 FROM_HERE,
160 base::Bind(&ExternalMetrics::CollectEventsAndReschedule, 158 base::Bind(&ExternalMetrics::CollectEventsAndReschedule,
161 weak_factory_.GetWeakPtr()), 159 weak_factory_.GetWeakPtr()),
162 base::TimeDelta::FromSeconds(kExternalMetricsCollectionIntervalSeconds)); 160 base::TimeDelta::FromSeconds(kExternalMetricsCollectionIntervalSeconds));
163 DCHECK(result); 161 DCHECK(result);
164 } 162 }
165 163
166 } // namespace metrics 164 } // namespace metrics
167 } // namespace chromecast 165 } // namespace chromecast
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698