Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: pkg/analysis_server/test/integration/integration_tests.dart

Issue 2691763002: Add integration tests for the execution domain. (Closed)
Patch Set: call -> request in dartdocs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/integration_tests.dart b/pkg/analysis_server/test/integration/integration_tests.dart
index d277f2cf0d27efeccd27c5988fd20959a275c151..59cbe570f4d8b38a483205bef226d3f910e4d7f2 100644
--- a/pkg/analysis_server/test/integration/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/integration_tests.dart
@@ -280,6 +280,17 @@ abstract class AbstractAnalysisServerIntegrationTest
}
/**
+ * An error result from a server request.
+ */
+class ServerErrorMessage {
+ final Map message;
+
+ ServerErrorMessage(this.message);
+
+ dynamic get error => message['error'];
+}
+
+/**
* Wrapper class for Matcher which doesn't create the underlying Matcher object
* until it is needed. This is necessary in order to create matchers that can
* refer to themselves (so that recursive data structures can be represented).
@@ -577,9 +588,7 @@ class Server {
_pendingCommands.remove(id);
}
if (messageAsMap.containsKey('error')) {
- // TODO(paulberry): propagate the error info to the completer.
- completer.completeError(new UnimplementedError(
- 'Server responded with an error: ${JSON.encode(message)}'));
+ completer.completeError(new ServerErrorMessage(messageAsMap));
} else {
completer.complete(messageAsMap['result']);
}

Powered by Google App Engine
This is Rietveld 408576698