Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 269173006: Issue 18438. Don't apply formatting to code lines in DartDoc. (Closed)

Created:
6 years, 7 months ago by scheglov
Modified:
6 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java View 2 chunks +27 lines, -10 lines 2 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilitiesTest.java View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 7 months ago (2014-05-06 21:14:48 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/269173006/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java (right): https://codereview.chromium.org/269173006/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java#newcode486 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java:486: if (line.startsWith(" ") || line.startsWith("<pre> ")) { The ...
6 years, 7 months ago (2014-05-06 21:50:50 UTC) #2
scheglov
https://codereview.chromium.org/269173006/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java (right): https://codereview.chromium.org/269173006/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java#newcode486 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java:486: if (line.startsWith(" ") || line.startsWith("<pre> ")) { On 2014/05/06 ...
6 years, 7 months ago (2014-05-06 23:42:56 UTC) #3
scheglov
6 years, 7 months ago (2014-05-06 23:43:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r35839 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698