Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26917003: Move DOMWindow and related clases from page/ to frame/ (Closed)

Created:
7 years, 2 months ago by eseidel
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Michael van Ouwerkerk, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, alecflett, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, devtools-reviews_chromium.org, Inactive, kenneth.christiansen, loislo+blink_chromium.org, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, haraken, kojih, jsbell, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, groby+blinkspell_chromium.org, dgrogan
Visibility:
Public.

Description

Move DOMWindow and related clases from page/ to frame/ This isn't quite all of DOMWindow, but most of it is now in frame/ Some of these may need to be implemented by talking back to interfaces exposed by the embedder, but those will go through some sort of "host" client object. BUG=305811 TBR=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -4196 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/BindingSecurity.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/NPV8Object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8NPUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CustomXPathNSResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8DocumentLocationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8WorkerGlobalScopeCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 5 chunks +24 lines, -24 lines 0 comments Download
M Source/core/css/MediaList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleMedia.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TouchController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/WheelController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/DocumentEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventTargetFactory.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MessageEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MouseRelatedEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/UIEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/UIEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/WindowEventContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/AbstractView.idl View 1 chunk +3 lines, -0 lines 0 comments Download
A + Source/core/frame/AdjustViewSizeOrNot.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/BarProp.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/BarProp.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/BarProp.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/frame/Console.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/ConsoleBase.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/DOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/DOMWindow.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/frame/DOMWindowBase64.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/DOMWindowBase64.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/DOMWindowLifecycleNotifier.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/DOMWindowLifecycleNotifier.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/DOMWindowLifecycleObserver.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/DOMWindowLifecycleObserver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/frame/DOMWindowProperty.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/DOMWindowProperty.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/frame/DOMWindowTimers.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/DOMWindowTimers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Frame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Frame.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/frame/FrameDestructionObserver.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/FrameDestructionObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/History.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/ImageBitmap.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/ImageBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/ImageBitmap.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/ImageBitmapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Location.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Location.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Navigator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Screen.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/Window.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/WindowBase64.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/WindowTimers.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/appcache/ApplicationCache.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/page/AbstractView.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/core/page/AdjustViewSizeOrNot.h View 1 chunk +0 lines, -38 lines 0 comments Download
D Source/core/page/BarProp.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/core/page/BarProp.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/page/BarProp.idl View 1 chunk +0 lines, -32 lines 0 comments Download
M Source/core/page/CreateWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DOMSelection.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/page/DOMWindow.h View 1 chunk +0 lines, -444 lines 0 comments Download
D Source/core/page/DOMWindow.cpp View 1 chunk +0 lines, -1775 lines 0 comments Download
D Source/core/page/DOMWindowBase64.h View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/page/DOMWindowBase64.cpp View 1 chunk +0 lines, -78 lines 0 comments Download
D Source/core/page/DOMWindowLifecycleNotifier.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/page/DOMWindowLifecycleNotifier.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
D Source/core/page/DOMWindowLifecycleObserver.h View 1 chunk +0 lines, -51 lines 0 comments Download
D Source/core/page/DOMWindowLifecycleObserver.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
M Source/core/page/DOMWindowPagePopup.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/page/DOMWindowProperty.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/core/page/DOMWindowProperty.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D Source/core/page/DOMWindowTimers.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/core/page/DOMWindowTimers.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
M Source/core/page/EventSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/page/FrameDestructionObserver.h View 1 chunk +0 lines, -51 lines 0 comments Download
D Source/core/page/FrameDestructionObserver.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/core/page/ImageBitmap.h View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/core/page/ImageBitmap.cpp View 1 chunk +0 lines, -200 lines 0 comments Download
D Source/core/page/ImageBitmap.idl View 1 chunk +0 lines, -9 lines 0 comments Download
D Source/core/page/ImageBitmapTest.cpp View 1 chunk +0 lines, -209 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/page/Window.idl View 1 chunk +0 lines, -315 lines 0 comments Download
D Source/core/page/WindowBase64.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/core/page/WindowTimers.idl View 1 chunk +0 lines, -37 lines 0 comments Download
M Source/core/plugins/DOMMimeType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/plugins/DOMMimeTypeArray.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/plugins/DOMPlugin.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/plugins/DOMPluginArray.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/storage/Storage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/Performance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/PerformanceNavigation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/PerformanceTiming.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/Worker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/DOMWindowCrypto.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/DOMWindowCrypto.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceSensorEventController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/NewDeviceOrientationController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/donottrack/NavigatorDoNotTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DOMWindowFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/NavigatorGeolocation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/DOMWindowIndexedDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/DOMWindowIndexedDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/DOMWindowNotifications.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/DOMWindowNotifications.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DOMWindowQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DOMWindowQuota.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/NavigatorStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/WorkerNavigatorStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/InspectorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/StorageAreaProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebBindings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDOMMessageEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
eseidel
7 years, 2 months ago (2013-10-11 03:02:57 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r159414 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698