ios/chrome/browser/tabs/tab_unittest.mm - Issue 2691693002: Relanding "Fixed title updating for back forward navigation."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab_unittest.mm

Issue 2691693002: Relanding "Fixed title updating for back forward navigation." (Closed)

Patch Set: Addressed review comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab_unittest.mm

diff --git a/ios/chrome/browser/tabs/tab_unittest.mm b/ios/chrome/browser/tabs/tab_unittest.mm

index c611f47d9a23cd5fee916c84a4e2593faeb05d72..d863fa33d3bda575307b50090ba71e2ef0be14c3 100644

--- a/ios/chrome/browser/tabs/tab_unittest.mm

+++ b/ios/chrome/browser/tabs/tab_unittest.mm

@@ -242,6 +242,8 @@ class TabTest : public BlockCleanupTest {

[[tab_ navigationManager]->GetSessionController() commitPendingItem];

[[tab_ webController] webStateImpl]->OnNavigationCommitted(redirectUrl);

[tab_ webDidStartLoadingURL:redirectUrl shouldUpdateHistory:YES];

+ base::string16 new_title = base::SysNSStringToUTF16(title);

+ [tab_ navigationManager]->GetLastCommittedItem()->SetTitle(new_title);

[tab_ webController:mock_web_controller_ titleDidChange:title];

[[[(id)mock_web_controller_ expect]

andReturnValue:OCMOCK_VALUE(kPageLoaded)] loadPhase];

« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »