Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: net/quic/chromium/quic_stream_factory_test.cc

Issue 2691683003: Remove OnCertDBChanged |cert| parameter. (Closed)
Patch Set: comment wording Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/chromium/quic_stream_factory.cc ('k') | net/socket/client_socket_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/chromium/quic_stream_factory.h" 5 #include "net/quic/chromium/quic_stream_factory.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <ostream> 8 #include <ostream>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 4342 matching lines...) Expand 10 before | Expand all | Expand 10 after
4353 /*cert_verify_flags=*/0, url_, "GET", net_log_, 4353 /*cert_verify_flags=*/0, url_, "GET", net_log_,
4354 callback_.callback())); 4354 callback_.callback()));
4355 4355
4356 EXPECT_THAT(callback_.WaitForResult(), IsOk()); 4356 EXPECT_THAT(callback_.WaitForResult(), IsOk());
4357 std::unique_ptr<QuicHttpStream> stream = request.CreateStream(); 4357 std::unique_ptr<QuicHttpStream> stream = request.CreateStream();
4358 HttpRequestInfo request_info; 4358 HttpRequestInfo request_info;
4359 EXPECT_EQ(OK, stream->InitializeStream(&request_info, DEFAULT_PRIORITY, 4359 EXPECT_EQ(OK, stream->InitializeStream(&request_info, DEFAULT_PRIORITY,
4360 net_log_, CompletionCallback())); 4360 net_log_, CompletionCallback()));
4361 4361
4362 // Change the CA cert and verify that stream saw the event. 4362 // Change the CA cert and verify that stream saw the event.
4363 factory_->OnCertDBChanged(nullptr); 4363 factory_->OnCertDBChanged();
4364 EXPECT_EQ(ERR_CERT_DATABASE_CHANGED, 4364 EXPECT_EQ(ERR_CERT_DATABASE_CHANGED,
4365 stream->ReadResponseHeaders(callback_.callback())); 4365 stream->ReadResponseHeaders(callback_.callback()));
4366 EXPECT_FALSE(factory_->require_confirmation()); 4366 EXPECT_FALSE(factory_->require_confirmation());
4367 4367
4368 // Now attempting to request a stream to the same origin should create 4368 // Now attempting to request a stream to the same origin should create
4369 // a new session. 4369 // a new session.
4370 4370
4371 QuicStreamRequest request2(factory_.get()); 4371 QuicStreamRequest request2(factory_.get());
4372 EXPECT_EQ(ERR_IO_PENDING, 4372 EXPECT_EQ(ERR_IO_PENDING,
4373 request2.Request(host_port_pair_, privacy_mode_, 4373 request2.Request(host_port_pair_, privacy_mode_,
(...skipping 1311 matching lines...) Expand 10 before | Expand all | Expand 10 after
5685 // Clear all cached states. 5685 // Clear all cached states.
5686 factory_->ClearCachedStatesInCryptoConfig( 5686 factory_->ClearCachedStatesInCryptoConfig(
5687 base::Callback<bool(const GURL&)>()); 5687 base::Callback<bool(const GURL&)>());
5688 EXPECT_TRUE(test_cases[0].state->certs().empty()); 5688 EXPECT_TRUE(test_cases[0].state->certs().empty());
5689 EXPECT_TRUE(test_cases[1].state->certs().empty()); 5689 EXPECT_TRUE(test_cases[1].state->certs().empty());
5690 EXPECT_TRUE(test_cases[2].state->certs().empty()); 5690 EXPECT_TRUE(test_cases[2].state->certs().empty());
5691 } 5691 }
5692 5692
5693 } // namespace test 5693 } // namespace test
5694 } // namespace net 5694 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/chromium/quic_stream_factory.cc ('k') | net/socket/client_socket_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698