Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: net/cert/cert_database_android.cc

Issue 2691683003: Remove OnCertDBChanged |cert| parameter. (Closed)
Patch Set: comment wording Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cert/cert_database.cc ('k') | net/cert/cert_database_mac.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/cert_database.h" 5 #include "net/cert/cert_database.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/observer_list_threadsafe.h" 8 #include "base/observer_list_threadsafe.h"
9 #include "net/base/net_errors.h" 9 #include "net/base/net_errors.h"
10 #include "net/ssl/openssl_client_key_store.h" 10 #include "net/ssl/openssl_client_key_store.h"
11 11
12 namespace net { 12 namespace net {
13 13
14 CertDatabase::CertDatabase() 14 CertDatabase::CertDatabase()
15 : observer_list_(new base::ObserverListThreadSafe<Observer>) { 15 : observer_list_(new base::ObserverListThreadSafe<Observer>) {
16 } 16 }
17 17
18 CertDatabase::~CertDatabase() {} 18 CertDatabase::~CertDatabase() {}
19 19
20 void CertDatabase::OnAndroidKeyStoreChanged() { 20 void CertDatabase::OnAndroidKeyStoreChanged() {
21 NotifyObserversCertDBChanged(NULL); 21 NotifyObserversCertDBChanged();
22 // Dump the OpenSSLClientKeyStore to drop references to now disconnected 22 // Dump the OpenSSLClientKeyStore to drop references to now disconnected
23 // PrivateKeys stored in the in-memory key store. Note: this assumes that 23 // PrivateKeys stored in the in-memory key store. Note: this assumes that
24 // every SSLClientAuthCache is dumped as part of notifying 24 // every SSLClientAuthCache is dumped as part of notifying
25 // OnCertDBChanged. Otherwise client auth decisions will be silently converted 25 // OnCertDBChanged. Otherwise client auth decisions will be silently converted
26 // to no-certificate decisions. See https://crbug.com/382696 26 // to no-certificate decisions. See https://crbug.com/382696
27 OpenSSLClientKeyStore::GetInstance()->Flush(); 27 OpenSSLClientKeyStore::GetInstance()->Flush();
28 } 28 }
29 29
30 void CertDatabase::OnAndroidKeyChainChanged() { 30 void CertDatabase::OnAndroidKeyChainChanged() {
31 observer_list_->Notify(FROM_HERE, &Observer::OnCertDBChanged, nullptr); 31 observer_list_->Notify(FROM_HERE, &Observer::OnCertDBChanged);
32 } 32 }
33 33
34 } // namespace net 34 } // namespace net
OLDNEW
« no previous file with comments | « net/cert/cert_database.cc ('k') | net/cert/cert_database_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698