Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: media/blink/cdm_session_adapter.cc

Issue 2691673002: media: Add UMA to record time to GenerateRequest and LoadSession (Closed)
Patch Set: comments addressed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/cdm_session_adapter.h ('k') | media/blink/new_session_cdm_result_promise.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/cdm_session_adapter.cc
diff --git a/media/blink/cdm_session_adapter.cc b/media/blink/cdm_session_adapter.cc
index d52ccadce7f9db57d7d8d0f35801ddefba67d911..eab2aef2c509848e77e48b5f430b67effb613c15 100644
--- a/media/blink/cdm_session_adapter.cc
+++ b/media/blink/cdm_session_adapter.cc
@@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/logging.h"
#include "base/metrics/histogram.h"
+#include "base/metrics/histogram_functions.h"
#include "base/stl_util.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/trace_event/trace_event.h"
@@ -166,7 +167,8 @@ void CdmSessionAdapter::OnCdmCreated(
kMediaEME + GetKeySystemNameForUMA(key_system) + kDot;
// Only report time for successful CDM creation.
- ReportTimeToCreateCdmUMA(base::TimeTicks::Now() - start_time);
+ base::UmaHistogramTimes(key_system_uma_prefix_ + kTimeToCreateCdmUMAName,
+ base::TimeTicks::Now() - start_time);
cdm_ = cdm;
@@ -240,14 +242,4 @@ WebContentDecryptionModuleSessionImpl* CdmSessionAdapter::GetSession(
return (session != sessions_.end()) ? session->second.get() : NULL;
}
-void CdmSessionAdapter::ReportTimeToCreateCdmUMA(base::TimeDelta time) const {
- // Note: This leaks memory, which is expected behavior.
- base::HistogramBase* histogram = base::Histogram::FactoryTimeGet(
- GetKeySystemUMAPrefix() + kTimeToCreateCdmUMAName,
- base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromSeconds(10),
- 50, base::HistogramBase::kUmaTargetedHistogramFlag);
-
- histogram->AddTime(time);
-}
-
} // namespace media
« no previous file with comments | « media/blink/cdm_session_adapter.h ('k') | media/blink/new_session_cdm_result_promise.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698