Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: components/exo/compositor_frame_sink_holder.cc

Issue 2691453002: [cc] Track observer status in ExternalBeginFrameSource. (Closed)
Patch Set: Call DidFinishFrame even when dropped, update tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/compositor_frame_sink_holder.cc
diff --git a/components/exo/compositor_frame_sink_holder.cc b/components/exo/compositor_frame_sink_holder.cc
index df76d11728662eb9edd013eecc625f08d04c934f..9b8a9397b14fc84268843342432b6499f76c3db7 100644
--- a/components/exo/compositor_frame_sink_holder.cc
+++ b/components/exo/compositor_frame_sink_holder.cc
@@ -58,6 +58,7 @@ void CompositorFrameSinkHolder::DidReceiveCompositorFrameAck() {
}
void CompositorFrameSinkHolder::OnBeginFrame(const cc::BeginFrameArgs& args) {
+ // TODO(eseckler): Hook up exo::Surface to the ExternalBFS.
reveman 2017/02/21 22:40:05 nit: s/exo::Surface/|surface_|/ and s/ExternalBFS/
Eric Seckler 2017/02/22 09:12:34 Done.
if (surface_)
surface_->BeginFrame(args.frame_time);
@@ -102,6 +103,10 @@ void CompositorFrameSinkHolder::OnNeedsBeginFrames(bool needs_begin_frames) {
frame_sink_->SetNeedsBeginFrame(needs_begin_frames);
}
+void CompositorFrameSinkHolder::OnDidFinishFrame(const cc::BeginFrameAck& ack) {
+ // TODO(eseckler): Pass on the ack to frame_sink_.
+}
+
////////////////////////////////////////////////////////////////////////////////
// SurfaceObserver overrides:

Powered by Google App Engine
This is Rietveld 408576698