Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: components/exo/compositor_frame_sink_holder.cc

Issue 2691453002: [cc] Track observer status in ExternalBeginFrameSource. (Closed)
Patch Set: Fix android compile errors. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/exo/compositor_frame_sink_holder.h" 5 #include "components/exo/compositor_frame_sink_holder.h"
6 6
7 #include "cc/resources/returned_resource.h" 7 #include "cc/resources/returned_resource.h"
8 #include "components/exo/surface.h" 8 #include "components/exo/surface.h"
9 9
10 namespace exo { 10 namespace exo {
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 } 51 }
52 52
53 //////////////////////////////////////////////////////////////////////////////// 53 ////////////////////////////////////////////////////////////////////////////////
54 // cc::mojom::MojoCompositorFrameSinkClient overrides: 54 // cc::mojom::MojoCompositorFrameSinkClient overrides:
55 55
56 void CompositorFrameSinkHolder::DidReceiveCompositorFrameAck() { 56 void CompositorFrameSinkHolder::DidReceiveCompositorFrameAck() {
57 // TODO(staraz): Implement this 57 // TODO(staraz): Implement this
58 } 58 }
59 59
60 void CompositorFrameSinkHolder::OnBeginFrame(const cc::BeginFrameArgs& args) { 60 void CompositorFrameSinkHolder::OnBeginFrame(const cc::BeginFrameArgs& args) {
61 // TODO(eseckler): Hook up exo::Surface to the ExternalBFS.
61 if (surface_) 62 if (surface_)
62 surface_->BeginFrame(args.frame_time); 63 surface_->BeginFrame(args.frame_time);
63 64
64 begin_frame_source_->OnBeginFrame(args); 65 begin_frame_source_->OnBeginFrame(args);
65 } 66 }
66 67
67 void CompositorFrameSinkHolder::ReclaimResources( 68 void CompositorFrameSinkHolder::ReclaimResources(
68 const cc::ReturnedResourceArray& resources) { 69 const cc::ReturnedResourceArray& resources) {
69 for (auto& resource : resources) { 70 for (auto& resource : resources) {
70 auto it = release_callbacks_.find(resource.id); 71 auto it = release_callbacks_.find(resource.id);
(...skipping 22 matching lines...) Expand all
93 94
94 void CompositorFrameSinkHolder::OnBeginFrameSourcePausedChanged(bool paused) {} 95 void CompositorFrameSinkHolder::OnBeginFrameSourcePausedChanged(bool paused) {}
95 96
96 //////////////////////////////////////////////////////////////////////////////// 97 ////////////////////////////////////////////////////////////////////////////////
97 // cc::ExternalBeginFrameSouceClient overrides: 98 // cc::ExternalBeginFrameSouceClient overrides:
98 99
99 void CompositorFrameSinkHolder::OnNeedsBeginFrames(bool needs_begin_frames) { 100 void CompositorFrameSinkHolder::OnNeedsBeginFrames(bool needs_begin_frames) {
100 frame_sink_->SetNeedsBeginFrame(needs_begin_frames); 101 frame_sink_->SetNeedsBeginFrame(needs_begin_frames);
101 } 102 }
102 103
104 void CompositorFrameSinkHolder::OnDidFinishFrame(const cc::BeginFrameAck& ack) {
105 // TODO(eseckler): Pass on the ack to frame_sink_.
106 }
107
103 //////////////////////////////////////////////////////////////////////////////// 108 ////////////////////////////////////////////////////////////////////////////////
104 // SurfaceObserver overrides: 109 // SurfaceObserver overrides:
105 110
106 void CompositorFrameSinkHolder::OnSurfaceDestroying(Surface* surface) { 111 void CompositorFrameSinkHolder::OnSurfaceDestroying(Surface* surface) {
107 surface_->RemoveSurfaceObserver(this); 112 surface_->RemoveSurfaceObserver(this);
108 surface_ = nullptr; 113 surface_ = nullptr;
109 } 114 }
110 115
111 //////////////////////////////////////////////////////////////////////////////// 116 ////////////////////////////////////////////////////////////////////////////////
112 // ExoComopositorFrameSink, private: 117 // ExoComopositorFrameSink, private:
113 118
114 CompositorFrameSinkHolder::~CompositorFrameSinkHolder() { 119 CompositorFrameSinkHolder::~CompositorFrameSinkHolder() {
115 if (surface_) 120 if (surface_)
116 surface_->RemoveSurfaceObserver(this); 121 surface_->RemoveSurfaceObserver(this);
117 } 122 }
118 123
119 void CompositorFrameSinkHolder::UpdateNeedsBeginFrame() { 124 void CompositorFrameSinkHolder::UpdateNeedsBeginFrame() {
120 if (!begin_frame_source_) 125 if (!begin_frame_source_)
121 return; 126 return;
122 127
123 bool needs_begin_frame = surface_ && surface_->NeedsBeginFrame(); 128 bool needs_begin_frame = surface_ && surface_->NeedsBeginFrame();
124 if (needs_begin_frame == needs_begin_frame_) 129 if (needs_begin_frame == needs_begin_frame_)
125 return; 130 return;
126 131
127 needs_begin_frame_ = needs_begin_frame; 132 needs_begin_frame_ = needs_begin_frame;
128 OnNeedsBeginFrames(needs_begin_frame_); 133 OnNeedsBeginFrames(needs_begin_frame_);
129 } 134 }
130 135
131 } // namespace exo 136 } // namespace exo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698