Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2691433004: Support virtual fields in DDC without requiring the @virtual annotation.

Created:
3 years, 10 months ago by kasperl
Modified:
3 years, 10 months ago
Reviewers:
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support virtual fields in DDC without requiring the @virtual annotation. Implementation builds on floitsch@'s idea of inserting synthetic classes to upgrade a non-virtual field to a virtual field (called virtualizing). It is strictly pay-per-use, so unless you override a field or access a field through `super` there is no cost associated with the support. BUG=https://github.com/dart-lang/sdk/issues/27385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+851 lines, -22 lines) Patch
M pkg/dev_compiler/lib/src/compiler/class_property_model.dart View 6 chunks +91 lines, -6 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 11 chunks +93 lines, -16 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A tests/language_strong/field_override5_test.dart View 1 chunk +512 lines, -0 lines 0 comments Download
A tests/language_strong/field_override6_test.dart View 1 chunk +126 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
kasperl
3 years, 10 months ago (2017-02-10 13:20:11 UTC) #1 
Description was changed from

==========
Support virtual fields in DDC without requiring the @virtual annotation.

Implementation builds on floitsch@'s idea of inserting synthetic classes
to upgrade a non-virtual field to a virtual field (called virtualizing).
It is strictly per-per-use, so unless you override a field or access a
field through `super` there is no cost associated with the support.

BUG=https://github.com/dart-lang/sdk/issues/27385
==========

to

==========
Support virtual fields in DDC without requiring the @virtual annotation.

Implementation builds on floitsch@'s idea of inserting synthetic classes
to upgrade a non-virtual field to a virtual field (called virtualizing).
It is strictly pay-per-use, so unless you override a field or access a
field through `super` there is no cost associated with the support.

BUG=https://github.com/dart-lang/sdk/issues/27385
==========

Powered by Google App Engine
This is Rietveld 408576698