Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 269143002: Initialize the SkFontConfigInterface singleton with SkOnce. (Closed)

Created:
6 years, 7 months ago by bungeman-skia
Modified:
6 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Initialize the SkFontConfigInterface singleton with SkOnce. BUG=chromium:369257 R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=14583

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/ports/SkFontConfigInterface_direct.cpp View 1 2 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bungeman-skia
6 years, 7 months ago (2014-05-05 21:37:28 UTC) #1
mtklein
https://codereview.chromium.org/269143002/diff/20001/src/ports/SkFontConfigInterface_direct.cpp File src/ports/SkFontConfigInterface_direct.cpp (right): https://codereview.chromium.org/269143002/diff/20001/src/ports/SkFontConfigInterface_direct.cpp#newcode128 src/ports/SkFontConfigInterface_direct.cpp:128: singleton = new SkFontConfigInterfaceDirect; Is it not *singleton = ...
6 years, 7 months ago (2014-05-05 21:42:50 UTC) #2
bungeman-skia
https://codereview.chromium.org/269143002/diff/20001/src/ports/SkFontConfigInterface_direct.cpp File src/ports/SkFontConfigInterface_direct.cpp (right): https://codereview.chromium.org/269143002/diff/20001/src/ports/SkFontConfigInterface_direct.cpp#newcode128 src/ports/SkFontConfigInterface_direct.cpp:128: singleton = new SkFontConfigInterfaceDirect; On 2014/05/05 21:42:50, mtklein wrote: ...
6 years, 7 months ago (2014-05-05 21:52:21 UTC) #3
mtklein
LGTM We should probably ping the bug and let them know this fixes the problem, ...
6 years, 7 months ago (2014-05-05 21:55:28 UTC) #4
bungeman-skia
6 years, 7 months ago (2014-05-05 22:34:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r14583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698