Add AstBuilder support for import and export directives.

Add AstBuilder support for import and export directives.

Still not supported yet: conditional URIs.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/528bebc00f85061a8f115d887f9a9d1c105f48ab

[Paul Berry, 2017-02-17 17:58:09]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-02-17 18:04:41]

LGTM

https://codereview.chromium.org/2691423007/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/listener.dart (right):

https://codereview.chromium.org/2691423007/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/listener.dart:283: void endImport(Token
importKeyword, Token DeferredKeyword, Token asKeyword,
It's a bit surprising that we have a comment like with for export in AST
builder, but not for endImport(). And here we have for endImport(), but not for
endExport() :-)

[Paul Berry, 2017-02-17 18:10:09]

https://codereview.chromium.org/2691423007/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/listener.dart (right):

https://codereview.chromium.org/2691423007/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/listener.dart:283: void endImport(Token
importKeyword, Token DeferredKeyword, Token asKeyword,
On 2017/02/17 18:04:40, scheglov wrote:
> It's a bit surprising that we have a comment like with for export in AST
> builder, but not for endImport(). And here we have for endImport(), but not
for
> endExport() :-)

Whoops, I meant to put all the comments on the base class.  Will fix before
committing.

[Paul Berry, 2017-02-17 18:23:35]

Description was changed from

==========
Add AstBuilder support for import and export directives.

Still not supported yet: conditional URIs.
==========

to

==========
Add AstBuilder support for import and export directives.

Still not supported yet: conditional URIs.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/528bebc00f85061a8f115d887f9a9d1c105f48ab
==========

[Paul Berry, 2017-02-17 18:23:37]

Committed patchset #2 (id:20001) manually as
528bebc00f85061a8f115d887f9a9d1c105f48ab (presubmit successful).

[ahe, 2017-02-20 14:57:13]

lgtm