Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc

Issue 2691423006: Introduce the ThrottleManager (Closed)
Patch Set: engedy review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc
diff --git a/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc b/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc
index cd036fd5c2452313844428a77a81b4053bff8658..4be0506e0e0445da1410d2316d73cc1cfb0c33d3 100644
--- a/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc
+++ b/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc
@@ -170,12 +170,15 @@ class ActivationStateComputingNavigationThrottleTest
if (!test_throttle_)
return;
ASSERT_EQ(navigation_handle, test_throttle_->navigation_handle());
- last_activation_state_ = test_throttle_->GetActivationState();
- if (last_activation_state_.value().activation_level ==
- ActivationLevel::DISABLED) {
- EXPECT_FALSE(test_throttle_->ReleaseFilter());
+ if (test_throttle_->filter())
+ test_throttle_->WillSendActivationToRenderer();
+
+ if (auto filter = test_throttle_->ReleaseFilter()) {
+ EXPECT_NE(ActivationLevel::DISABLED,
+ filter->activation_state().activation_level);
+ last_activation_state_ = filter->activation_state();
} else {
- EXPECT_TRUE(test_throttle_->ReleaseFilter());
+ last_activation_state_ = ActivationState(ActivationLevel::DISABLED);
}
}

Powered by Google App Engine
This is Rietveld 408576698