components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc - Issue 2691423006: Introduce the ThrottleManager

Unified Diff: components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc

Issue 2691423006: Introduce the ThrottleManager (Closed)

Patch Set: fix activation state unit tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « components/subresource_filter/content/browser/async_document_subresource_filter.cc ('k') | components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h » ('j') | content/public/test/navigation_simulator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc

diff --git a/components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc b/components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc

index 121f67dcd7d1f7f5d78516b1ec06a14cbdb9ecc8..88a08629c347ff09704351b95de9d0efc611efaa 100644

--- a/components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc

+++ b/components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc

@@ -141,8 +141,7 @@ TEST_F(AsyncDocumentSubresourceFilterTest, ActivationStateIsReported) {

testing::TestActivationStateCallbackReceiver activation_state;

auto filter = base::MakeUnique<AsyncDocumentSubresourceFilter>(

- ruleset_handle.get(), std::move(params), activation_state.GetCallback(),

- base::OnceClosure());

+ ruleset_handle.get(), std::move(params), activation_state.GetCallback());

RunUntilIdle();

activation_state.ExpectReceivedOnce(

@@ -159,8 +158,7 @@ TEST_F(AsyncDocumentSubresourceFilterTest, ActivationStateIsComputedCorrectly) {

testing::TestActivationStateCallbackReceiver activation_state;

auto filter = base::MakeUnique<AsyncDocumentSubresourceFilter>(

- ruleset_handle.get(), std::move(params), activation_state.GetCallback(),

- base::OnceClosure());

+ ruleset_handle.get(), std::move(params), activation_state.GetCallback());

RunUntilIdle();

@@ -180,8 +178,7 @@ TEST_F(AsyncDocumentSubresourceFilterTest, DisabledForCorruptRuleset) {

testing::TestActivationStateCallbackReceiver activation_state;

auto filter = base::MakeUnique<AsyncDocumentSubresourceFilter>(

- ruleset_handle.get(), std::move(params), activation_state.GetCallback(),

- base::OnceClosure());

+ ruleset_handle.get(), std::move(params), activation_state.GetCallback());

RunUntilIdle();

activation_state.ExpectReceivedOnce(

@@ -197,8 +194,7 @@ TEST_F(AsyncDocumentSubresourceFilterTest, GetLoadPolicyForSubdocument) {

testing::TestActivationStateCallbackReceiver activation_state;

auto filter = base::MakeUnique<AsyncDocumentSubresourceFilter>(

- ruleset_handle.get(), std::move(params), activation_state.GetCallback(),

- base::OnceClosure());

+ ruleset_handle.get(), std::move(params), activation_state.GetCallback());

LoadPolicyCallbackReceiver load_policy_1;

LoadPolicyCallbackReceiver load_policy_2;

@@ -222,7 +218,8 @@ TEST_F(AsyncDocumentSubresourceFilterTest, FirstDisallowedLoadIsReported) {

testing::TestActivationStateCallbackReceiver activation_state;

auto filter = base::MakeUnique<AsyncDocumentSubresourceFilter>(

- ruleset_handle.get(), std::move(params), activation_state.GetCallback(),

+ ruleset_handle.get(), std::move(params), activation_state.GetCallback());

+ filter->set_first_disallowed_load_callback(

first_disallowed_load_receiver.GetClosure());

LoadPolicyCallbackReceiver load_policy_1;