ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp - Issue 2691393005: MD WebUI: create a Chrome-only <paper-ripple> that's resistant to JS jank (via web animations API)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp

Issue 2691393005: MD WebUI: create a Chrome-only <paper-ripple> that's resistant to JS jank (via web animations API) (Closed)

Patch Set: closure Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js ('K') | « third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js ('k') | ui/file_manager/file_manager/foreground/elements/files_ripple.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp

diff --git a/ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp b/ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp

index 85e2919eb957d9dca0d1ca314601cf4515268d60..c8bac2ee47a5b82b1bd33a23ebac7337f878243e 100644

--- a/ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp

+++ b/ui/file_manager/file_manager/foreground/elements/compiled_resources2.gyp

@@ -31,6 +31,7 @@

'dependencies': [

'<(DEPTH)/third_party/polymer/v1_0/components-chromium/paper-ripple/compiled_resources2.gyp:paper-ripple-extracted',

oka 2017/02/23 06:40:43 Could you remove this line?

oka 2017/02/23 06:41:30 (I've locally confirmed that code compiles after t

Dan Beam 2017/02/23 20:01:15 Done.

'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',

+ '<(EXTERNS_GYP):web_animations',

'includes': ['../../../compile_js2.gypi'],