Issue 2691393004: Remove two flags from dartanalyzer running in test.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2691393004: Remove two flags from dartanalyzer running in test.dart (Closed)

Created:
3 years, 10 months ago by Bill Hesse

Modified:
3 years, 10 months ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove two flags from dartanalyzer running in test.dart BUG= R=devoncarew@google.com Committed: https://github.com/dart-lang/sdk/commit/389fa9532004b3d939ca6e901c07bc8694b6b9ab

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

devoncarew

lgtm lgtm Konstantin, can you remember why you added '--show-package-warnings'? (~4 years ago)

3 years, 10 months ago (2017-02-16 00:50:40 UTC) #3

Bill Hesse

Committed patchset #1 (id:1) manually as 389fa9532004b3d939ca6e901c07bc8694b6b9ab (presubmit successful).

3 years, 10 months ago (2017-02-16 00:56:07 UTC) #5

scheglov

3 years, 10 months ago (2017-02-16 01:01:47 UTC) #6

Message was sent while issue was closed.

On 2017/02/16 00:50:40, devoncarew wrote:
> lgtm
> 
> lgtm
> 
> Konstantin, can you remember why you added '--show-package-warnings'?  (~4
years
> ago)

I see that I added it in git log, but I have no idea why :-)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages