ui/views/controls/webview/OWNERS - Issue 2691383002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/controls/webview/OWNERS

Issue 2691383002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Patch Set: update team/component Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 miu@chromium.org	1 miu@chromium.org

2 sadrul@chromium.org	2 sadrul@chromium.org

3 sky@chromium.org	3 sky@chromium.org

	4

	5 # COMPONENT: UI>Browser>TabContents
	sky 2017/02/15 23:20:36 In general patches in this area are more related t In general patches in this area are more related to views than to TabContents. So, I don't think this is the right component. ymzhang1 2017/02/15 23:41:22 Oops, seems we got disagreement here. miu@, sky@ Show quoted text On 2017/02/15 23:20:36, sky wrote: > In general patches in this area are more related to views than to TabContents. > So, I don't think this is the right component. Oops, seems we got disagreement here. miu@, sky@ It would be better to have one primary component for each directory. Which component would be better? Owner could also help to create a new component if none is good here. Thanks! https://bugs.chromium.org/p/chromium/issues/entry?template=Component%20Request sky 2017/02/16 00:24:05 I wouldn't recommend adding any component at all h Show quoted text On 2017/02/15 23:41:22, ymzhang1 wrote: > On 2017/02/15 23:20:36, sky wrote: > > In general patches in this area are more related to views than to TabContents. > > So, I don't think this is the right component. > > Oops, seems we got disagreement here. > miu@, sky@ > It would be better to have one primary component for each directory. Which > component would be better? > > Owner could also help to create a new component if none is good here. Thanks! > https://bugs.chromium.org/p/chromium/issues/entry?template=Component%20Request I wouldn't recommend adding any component at all here. It should inherit it from ui/views. ymzhang1 2017/02/16 22:15:17 Sure. I'll remove this line. Thanks. Show quoted text On 2017/02/16 00:24:05, sky wrote: > On 2017/02/15 23:41:22, ymzhang1 wrote: > > On 2017/02/15 23:20:36, sky wrote: > > > In general patches in this area are more related to views than to > TabContents. > > > So, I don't think this is the right component. > > > > Oops, seems we got disagreement here. > > miu@, sky@ > > It would be better to have one primary component for each directory. Which > > component would be better? > > > > Owner could also help to create a new component if none is good here. Thanks! > > https://bugs.chromium.org/p/chromium/issues/entry?template=Component%20Request > > I wouldn't recommend adding any component at all here. It should inherit it from > ui/views. Sure. I'll remove this line. Thanks.
OLD	NEW

« no previous file with comments | « media/remoting/OWNERS ('k') | no next file » | no next file with comments »